[Lenny the Cup]

Thanks for your feedback Calgon, let me answer your questions

Quote:

Originally Posted by Calgon 1) Why are you creating defines for things you can define yourself, fair enough if the item was relatively important and needed to be used more than once (talking about the show markers define, that's easy to configure yourself).

It's to allow a user with basic to no scripting knowledge to adjust the script according to their preferences.

Quote:

Originally Posted by Calgon 2) Why are you creating excessive functions for features that are only used once?

The script is just a base and I'm confident the functions I've created so far will be used in other parts of the script than where they are right now. As for the dialog function, it's to give a proper overview of the script. I don't like scripts that have everything packed into one function, it gets incredibly messy.

Quote:

Originally Posted by Calgon 3) Why are you using PVars? PVars are convenient, but the lookup speed is slower than it is for normal variables. Seeing as krisk was the first one to find that out (well, according to the speed test/tutorial Carlton posted) I'm surprised you didn't know that, unless you have other reasoning behind using PVars.

PVars are convenient when dealing with variables that will only be used once per player or generally seldom. Using up 500 bytes for something that's only checked once per OnPlayerConnect is pretty stupid in my opinion, and in this case I'm weighing memory over CPU performance. You won't see a lot of PVars in the "finished" version though.

Quote:

Originally Posted by Calgon 4) You've inadvertently violated forum rule: "Don't post huge scripts. Use http://pawn.pastebin.com/ instead." Why don't you store the script (and plugins) in an SVN repository? I assume that would not only be more convenient for those who decide to use this script, it would probably also be convenient for developing on.

You're right, sorry. I can't really say it's huge yet though it's good you've given me the heads-up, and an SVN repository sounds like a great idea indeed!

Quote:

Originally Posted by Calgon 5) I'm a bit confused as to why this code compiles, seeing as (be it a minor mistake):

If you look in the notes for the release you'll see that I haven't made sure it compiles or runs, it's just something I created in an hour or so.

Quote:

Originally Posted by Calgon Other than that, the concept of a collaborative script sounds nice. Good luck pulling it off.

Thank you!