12.09.2010, 12:39
nice script but there are some things you can fix:
"CREATE TABLE" instead of "CREATE TABLE IF NOT EXISTS"
ShortName validation is a bit dodgy
no sql injection protection
no checks to see if the database opened correctly
if just checking if a row exists, "SELECT ROWID FROM" should be faster than "SELECT * FROM"
database connections are not always closed
magic numbers used alot
fair enough about the pages but 1024 is pertty small for a list dialog
sqlite is pretty tolerant, but ID='%d' should be ID=%d
"CREATE TABLE" instead of "CREATE TABLE IF NOT EXISTS"
ShortName validation is a bit dodgy
no sql injection protection
no checks to see if the database opened correctly
if just checking if a row exists, "SELECT ROWID FROM" should be faster than "SELECT * FROM"
database connections are not always closed
magic numbers used alot
fair enough about the pages but 1024 is pertty small for a list dialog
sqlite is pretty tolerant, but ID='%d' should be ID=%d