[BlueG]

Quote:

Originally Posted by Wicko I really love the whole queue idea. Great job, G-Stylezz. Again. Besides that: Код: [14:22:20] CMySQLHandler::Connect() - Connection was successful. [14:22:20] >> mysql_query( Connection handle: 1 ) [14:22:20] CMySQLHandler::Query(select * from hrp_door) - Successfully executed. [14:22:20] >> mysql_query( Connection handle: 1 ) [14:22:20] CMySQLHandler::Query(select * from hrp_gz) - An error has occured. (Error ID: 2014, Commands out of sync; you can't run this command now) [14:22:20] >> mysql_query( Connection handle: 1 ) [14:22:20] CMySQLHandler::Query(select * from hrp_anim) - An error has occured. (Error ID: 2014, Commands out of sync; you can't run this command now) [14:22:20] >> mysql_query( Connection handle: 1 )

First of all, thanks for your input. You get this error, because you didn't free or store your result anywhere.

Quote:

Originally Posted by mysql.com If you get Commands out of sync; you can't run this command now in your client code, you are calling client functions in the wrong order. This can happen, for example, if you are using mysql_use_result() and try to execute a new query before you have called mysql_free_result(). It can also happen if you try to execute two queries that return data without calling mysql_use_result() or mysql_store_result() in between.

The plugin doesn't free and/or store results anywhere, so you'll have to do it manually by calling the functions. (mysql_store_result() & mysql_free_result())

Quote:

Originally Posted by Wicko You do such a little, confusing thing in here: Код: cell AMX_NATIVE_CALL NativeFunctions::n_mysql_query( AMX* amx, cell* params ) { unsigned int cID = params[3]-1; MySQL_Log(">> mysql_query( Connection handle: %d )",cID+1); VALID_CONNECTION_HANDLE("mysql_query",cID); CMySQLHandler *cHandle = SQLHandle[cID]; cHandle->Query(AMX_H->GetString(amx,params[1]),params[2]); return 0; } Returning 0 I mean. In my plugin-cross-compatible code I just use (and used, even with the old version of your plugin) if(mysql_query()) to check whether I should process the query futher. You disallow the code to work by returning 0 whatever the result is - it's also incomatible with the older version. I also can't define a macro to check whether its equal to 0, as mysql_query() is not only used with if() (like in threaded queries), so the code would be quite crappy. I think you could simply return 0/1 with non-threaded queries, and -1 in threaded ones. The code would be backward compatible then.

To be honest, I didn't really care about the return value because I was busy with the whole threading code. Anyway, this is fixed in the latest binary and I'm going to release it later today.

Quote:

Originally Posted by Wicko It is made on purpose, or it's rather an omission, like: Quote: my_ulonglong CMySQLHandler::InsertId() { if(!m_bIsConnected) { NativeFunctions::MySQL_Log("CMySQLHandler::FreeResult() - There is nothing to free (Reason: Connection is dead)."); ? Regards!

No, this was obviously not made on purpose. It was rather a copy & paste message, which I forgot to edit before releasing.

Quote:

Originally Posted by Wicko EDIT: Another catch. Код: cell AMX_NATIVE_CALL NativeFunctions::n_mysql_fetch_field( AMX* amx, cell* params ) { /*MySQL.field = (MYm_stField *)malloc(100); MySQL.field = mysql_fetch_field_direct(MySQL.res, params[1]); AmxStringHandler->SetString(amx,params[2],std::string(MySQL.field->name)); MySQL_Log("mysql_fetch_field(Number: %d); Return: \"%s\"",params[1],MySQL.field->name); free(MySQL.field);*/ return 1; } You register the native which is never used.

I forgot about this function, but it's finished in the coming version today. Besides your input, I must admit that there was a bug with passing the correct connection handle to the callback which has been fixed now. Webflori figured this out, so thanks to him too.