[Infin1ty]

Quote:

Originally Posted by Pottus Well there is some stuff here...... 1.) No textdraw create in OnFilterScriptInit() for connected players. 2.) Using textdraws that should be global as player textdraws only textdraws with per-player output should be player textdraws. 3.) Lacking clean up code in OnFilterScriptExit() 4.) Major fuck-up with OnPlayerSpawn() that continually creates textdraws without destroying. Textdraws should never be destroyed unless the filterscript is unloaded. Your textdraws need to be created when a player connects ideally when they actually login. 5.) Useless OnPlayerDisconnect() code all of it. 6.) Why bother updating anything if nothing actually changed? Save the last CHANGE in a variable if it is the same then don't update. Code: if(angle >= 355.0 || angle <= 5.0) PlayerTextDrawSetString(playerid, p_DirectionTextdraw[playerid], "N"); else if(angle >= 265.0 && angle <= 275.0) PlayerTextDrawSetString(playerid, p_DirectionTextdraw[playerid], "E"); else if(angle >= 175.0 && angle <= 185.0) PlayerTextDrawSetString(playerid, p_DirectionTextdraw[playerid], "S"); else if(angle >= 85.0 && angle <= 95.0) PlayerTextDrawSetString(playerid, p_DirectionTextdraw[playerid], "W");

Thanks for all this. This was old code stuffed somewhere in my hard drive and I decided to make something out of it. I can’t believe I missed out this in my clean up process. I’ll work on this tomorrow and will push the updates. I was planning to make this a include or a gamemode module hence why some of the things listed in your list are there, I just seemed to forget that this was a filterscript, lmao.