[FilterScript] Dynamic Update System
#16

Quote:
Originally Posted by Kaperstone
Посмотреть сообщение
If you already use sscanf, you can make
/update [add, edit, etc.] rather than /editupdate /addupdate


Why are you using PVars?
What if I use "UID" PVar in my gamemode, that'd mean that your filterscript would overwrite my PVars

Код:
new str[256];
Max. length of a message that you can send in a SendClientMessage is 144, so the array must be 145 with one for terminal.

Код:
format(tmp4, sizeof(tmp4), "Updates\tDate Of Update\n%s", tmp3);
Код:
format(s, sizeof(s), "update%d", x);
Why are you using format to append string? use strcat
Format would just be slower for such simple task.

Код:
h[256]
The dates are around 10 char, surely not 256 char
Код:
%d/%d/%d
2+2+4+3=11 max.
You have 245 wasted cells


Код:
for(new x=1 ; x<560 ; x++)
            {
                new s[256];
Its better to create the array outside the loop than to create an array for every loop, would just eat up processing time, moreover, if you'd create it outside, empty the string every loop with ``string[0] = EOS;``


I've noticed that you haven't stated max. length of string for an update line to be?
Uhh if i say its my second fs then?
Thank you for telling my mistakes i will try to improve it.
Reply


Messages In This Thread
Dynamic Update System - by Usmanmemon - 14.12.2017, 19:01
Re: Dynamic Update System - by rfr - 14.12.2017, 19:02
Re: Dynamic Update System - by Usmanmemon - 14.12.2017, 19:06
Re: Dynamic Update System - by jasperschellekens - 14.12.2017, 20:40
Re: Dynamic Update System - by Usmanmemon - 16.12.2017, 21:01
Re: Dynamic Update System - by RogueDrifter - 16.12.2017, 21:29
Re: Dynamic Update System - by darkhunter332 - 16.12.2017, 21:54
Re: Dynamic Update System - by RoyalGamer - 17.12.2017, 05:31
Re: Dynamic Update System - by Usmanmemon - 20.12.2017, 15:40
Re: Dynamic Update System - by Usmanmemon - 20.12.2017, 15:42
Re: Dynamic Update System - by Kaperstone - 20.12.2017, 16:14
Re: Dynamic Update System - by rfr - 20.12.2017, 16:19
Re: Dynamic Update System - by Kaperstone - 20.12.2017, 16:30
Re: Dynamic Update System - by rfr - 20.12.2017, 16:41
Re: Dynamic Update System - by DonaldDuck - 21.12.2017, 14:14
Re: Dynamic Update System - by Usmanmemon - 21.12.2017, 15:05
Re: Dynamic Update System - by Usmanmemon - 21.12.2017, 15:11
Re: Dynamic Update System - by Barnwell - 23.12.2017, 12:34
Re: Dynamic Update System - by xMoBi - 23.12.2017, 13:04
Re: Dynamic Update System - by Usmanmemon - 23.12.2017, 20:07
Re: Dynamic Update System - by Usmanmemon - 24.12.2017, 10:11
Re: Dynamic Update System - by Usmanmemon - 24.12.2017, 10:13
Re: Dynamic Update System - by BulletRaja - 24.12.2017, 10:24
Re: Dynamic Update System - by Usmanmemon - 25.12.2017, 09:01
Re: Dynamic Update System - by leonardo23 - 28.03.2018, 23:45
Re: Dynamic Update System - by CaptainBoi - 13.01.2019, 07:59

Forum Jump:


Users browsing this thread: 11 Guest(s)