[RogueDrifter]

Quote:

Originally Posted by Xeon™ Ok here we go, I've reviewed your code. 1- Indentation is killed. 2- You forget #define FILTERSCRIPT 3- PHP Code: new versioncheck;  This variable will take only two cases, false or true, so you have to use bool: tag like this. PHP Code: new bool:versioncheck;  4- You are declaring 3 arrays for 3 strings you could optimize that by using only 2. 5- PHP Code: if(strcmp(versionstring, "0.3.7-R2"))//checking if that string has the wanted version. { }  waste of lines you could use PHP Code: if(!strcmp(versionstring, "0.3.7-R2"))  instead 6- PHP Code: format(messagestring, sizeof(messagestring), " Server Has Kicked %s, Reason : OLD CLIENT VERSION %s ", playername,versionstring); SendClientMessageToAll(-1,messagestring); SetTimerEx("DelayedKick",1000, false, "i", playerid);//delaying both the kick and the message to make sure the player gets the messages on time. SetTimerEx("DelayedMessages",500,false,"i",playerid);//thats  the delayed message  Delayed message waste of lines and CPU usage, you could send directly the messages (your messages won't appear to the player because the second one will be called after delayed kick finish and that's not cool. 7 - PHP Code: SetPlayerWeather(playerid, 999);//blinding the player on his disconnect to make sure he's totally out. SetPlayerVirtualWorld(playerid, 999);//same as above SetPlayerInterior(playerid,999);//same as above  You are wrong mate, these are a valid values. VW 999 exists same for others. 8- PHP Code: CMD:togversion(playerid,params[]) { if (IsPlayerAdmin(playerid))//change this to your admin system { if(versioncheck ==0)//if the version is ON {  versioncheck =1;  SendClientMessage(playerid,-1,".: VERSION OFF :.");  }  else if(versioncheck ==1)//if the version is OFF  {  versioncheck =0;  SendClientMessage(playerid,-1,".: VERSION ON :.");  }  } return 1;  }  I can do it on fewer lines like that: PHP Code:  CMD:togversion(playerid)  {      if(!IsPlayerAdmin(playerid)) return 1;      if(versioncheck == false) versioncheck = true, SendClientMessage(playerid,-1,".: VERSION ON :.");      else versioncheck = false, SendClientMessage(playerid,-1,".: VERSION OFF :.");      return 1;  }  spaghetti code... thanks for your shit long code mate! P.S: we need quality/rapidity, not the longer

Okay, here we go:
1- the indenation isn't killed.
2- the purpose was for this to be a snippet not an FS as i've said before in my post, anyone can put #define fs...
3- okay, that's true bool could've been used, made the code pretty quick so didn't notice.
4- i have no fucken clue what you said right there, using the same string for the version,message? the string formats the version what the fuck are you on about "mate" ?
5- i made the code, i wanted to give the ability to do something whether the version was true or false, that's why i put a comment there if you could put on your glasses and read well.
6- delayed the message to send them to the player, you can try it by yourself, send messages onplayerconnect and see if they're there every time, if that works i'll delete the thread.
7- the values do exist but im messing it all up as to when the player is kicked he can't see anything.
8- i don't think you read my post well, the reason for this was to " SHOW PEOPLE HOW ITS DONE ", but instead you got no shit to do so you come off by being a fuckhead to random people, well guess what, fuck you and your irrelevant code take that shit somewhere else you wanker.