Maybe. I think most serious servers are using SetSpawnInfo/SetPlayerSkin. AddPlayerClass is a leftover from SA-MP 0.1.
Yeah, that works.
If AddPlayerClass is a leftover from 0.1 on my opinion there should be a function to disable the class system and if someone joins the server they should spawn directly if this function is enabled.