[SyS]

Quote:

Originally Posted by Eoussama Select Random Player PHP Code: stock SelectRandomPlayer() {     new k = GetPlayerPoolSize(),i,j,T[k];     for(i=0; i<k; i++){         if(IsPlayerConnected(i)){             T[j] = i;             j++;         }     }     return T[random(j)]; }

Your code won't work and is not efficient.Because:

PHP Code:

new k = GetPlayerPoolSize(),T[k]; 


the above code isn't right.The variable k has unknown value and not constant at the time of compilation and pawn doesn't support dynamic initialization .So providing size k to array T will throw error.

Now in your algorithm you are creating an array for nothing all we need is a random player id. What you now doing is creating an array of connected players and randomizing the index of that array and returning the value in that index.Which is clearly a bad method.

You can either use foreach and use it's own builtin Iter_Random function to get random players from the iterator Player or if you want to do without foreach either modify this function to supporting a cache like system.That means change the content of the array (static or global one) only when a change in number of connected player or their id occurred and return the random id.So that the same process of creating an array is not required in each overhead.