[AndySedeyn]

Quote:

Originally Posted by Sreyas Code: else if(gTeam[playerid] == LSPD) { SendClientMessage(playerid, 0xFF0000, "[ERROR]: you can't use this on a law enforcer!"); return 1; { return 1; Code: else if(!IsPlayerConnected(targetid)) { SendClientMessage(playerid, 0xFF0000, "[ERROR]: Invalid ID!"); return 1! } fix that ^^ i didnt look much ahead and i wont raise hand to much use of else if s

While I usually don't complain about the excessive use of unnecessary else if statements, I do get annoyed by it. A lot of people find it reasonable to use them in a situation where the given condition can only be maximum two states and thus making an else if statement pointless and may even become "ineffective":

PHP Code:

if(IsPlayerConnected(playerid))
{
    // Some code ...
}
else
{
    if(!IsPlayerConnected(playerid))
    {
        // Some other code ...
    }
} 


Given that, it seems like the OP has a bad habit of doing just that. I see the following reoccur more than a few times throughout the tutorial:

PHP Code:

if(IsPlayerConnected(playerid))
{
    // Some code ...
    return 1;
}
else if(!IsPlayerConnected(playerid))
{
    // Some other code ...
    return 1;
} 


A player is either connected or not. In this case, a simple else statement is the best way to go.

To drop the whole else statement altogether, the function would have to return a value in the if statement above that:

PHP Code:

if(condition)
{
    // Some code...
    return someValue;
}
// Code under this if statement is automatically the else statement, that is without explicitely using the else keyword.
return someOtherValue; 


Not explicitly using the else statement may reduce readability for programmers who are used to using it in such cases. I tend to not use it, but I'm fine with either.

Here's another mistake I came across:

Quote:

Originally Posted by Eoussama PHP Code: if(IsCuffed == true) {     return 1; } else if(IsCuffed == true) {     return 1; }

EDIT: Your boolean variable 'isCuffed' will only work when nobody is cuffed. Once 1 player on the server is cuffed, nobody else can get cuffed.