[Spmn]

Quote:

Originally Posted by TreePuncher From what I read, I'll assume all reports are sent straight to the master server, no exceptions. With that assumption in mind, I think it'd be nice to have a callback where you decide whether that report is sent to the master server or just dropped. As you said, it's possible to have your admin banned accidentally by using admin commands, and the reason I am giving this idea is because, if that were to happen, the server could just go through whatever logical operation it was programmed to go through and drop the report if the admin was really using his commands, that way, the admin wouldn't have to go off duty for 24/48 hours, and you wouldn't have to review that appeal. Now that suggestion was just in case the plugin doesn't work like that, I did not have time to look at it. Sad, really.

I took a quick look at source code and it seems that only bans issued by NexAC are sent to master server.


Here's a couple of suggestions:
- call a callback when a global banned player connects instead of auto kicking it (maybe some server owners want to whitelist certain cheaters?)
- hook callbacks used by your library, especially OnCheatDetected because scripters might want to use that callback in their scripts too

I see you allow servers to issue global bans since they are registered on your master server. What if some malicious SA-MP servers send fake global bans? You should reject all bans unless issuer is trustable.