19.05.2015, 21:25
- Checking about mysql racing would be really good as in rare cases players can get the data from the previous player.
- Selecting all the player's data on connect once and comparing the password afterwards, if it matches assigning to variables directly instead of executing another query.
- In cache_get_field_content function, you need to set max_len parameter when enum-array is used.
- cache_get_row/cache_get_row_* functions is slightly faster than cache_get_field_content/cache_get_field_content_* but you could probably explain both and let the user decide which one (just a suggestion).
Other than that, good job I guess. By the way, this may help few people: https://sampwiki.blast.hk/wiki/MySQL/R33
- Selecting all the player's data on connect once and comparing the password afterwards, if it matches assigning to variables directly instead of executing another query.
- In cache_get_field_content function, you need to set max_len parameter when enum-array is used.
- cache_get_row/cache_get_row_* functions is slightly faster than cache_get_field_content/cache_get_field_content_* but you could probably explain both and let the user decide which one (just a suggestion).
Other than that, good job I guess. By the way, this may help few people: https://sampwiki.blast.hk/wiki/MySQL/R33