[Gammix]

Quote:

Originally Posted by Pottus Код: new index = (gMenu[menuid][M_LISTITEMS] + 1); if(index > MAX_MENU_ITEMS) return -1; index -= 1; Why not just do it like this. Код: new index = (gMenu[menuid][M_LISTITEMS]); if(index >= MAX_MENU_ITEMS) return -1;

Oh, yes.

Quote:

Originally Posted by Pottus The ordering in OnPlayerUpdate() could be done better for sure. pawn Код: new keys, updown, leftright;     GetPlayerKeys(playerid, keys, updown, leftright);     if(updown == KEY_DOWN)     {         if(GetPlayerMenuID(playerid) != INVALID_MENU_ID)         { You are already making function calls when you don't have to, this would be a better logical order. Код: if(GetPlayerMenuID(playerid) != INVALID_MENU_ID) { new keys, updown, leftright; GetPlayerKeys(playerid, keys, updown, leftright); if(updown == KEY_DOWN) {

Yes, thats right.

Quote:

Originally Posted by Pottus Another thing to keep in mind is you are using == to check for keys which will work but you can not be pressing any other keys! Usually keys are checked like below. I won't say this method as long as it was your intention for it to be that way. Код: if(updown & KEY_DOWN)

No that will work but for both KEY_DOWN and KEY_UP as well other keys. So that will probably collapse.


Updated the download !




playergui.pwn
You hooking mistake:

Quote:

#else #if defined _ALS_OnGameModeInit #undef OnGameModeInit #else #define _ALS_OnGameModeInit #endif #define OnFilterScriptInit GUIP_OnGameModeInit forward GUIP_OnGameModeInit(); #endif

pawn Код:

#define GUIValidIndex(%0) if(!GUIData[_:%0][GUIActive]) return 0
#define GUIValidElement(%0,%1) if(!GUIData[_:%0][GUIUsed][%1]) return 0

Or maybe this:

pawn Код:

#define GUIValidIndex(%0) return GUIData[_:%0][GUIActive]
#define GUIValidElement(%0,%1) return GUIData[_:%0][GUIUsed][%1]

The coding of your GUI is pretty good.
I like this method:

pawn Код:

#if defined FILTERSCRIPT
    public OnFilterScriptExit()
#else
    public OnGameModeExit()
#endif