Posts: 3,004
Threads: 12
Joined: May 2011
Quote:
Originally Posted by Vince
- Consider using a proper framework.
- HTML lang attribute is not specified.
- meta charset is not specified.
- Responsiveness is only so and so and text overlaps the images as the viewport gets smaller. Some stuff even goes off screen entirely. Smaller viewports should have the main menu hidden under what's know as a "hamburger-icon".
- Images do not have alt attributes. This is required.
- <font> is obsolete and inline styles are a huge no-no. The HTML source should not contain any styles. All styling is to be done via CSS.
- navigation should use <ul> (unordered list), regardless of placement. Navigation can be put horizontally with CSS.
- Text should not be put in uppercase in the HTML source. This can be styled with CSS.
Conclusion: visual aspect is one thing, but if your code is crap it won't do you much good and it can severely impact the page rank in search engines.
Useful:
http://validator.w3.org
http://validator.w3.org/nu (document outline)
https://jigsaw.w3.org/css-validator/
|
I don't use frameworks, frameworks slow down the code processing and I don't like it.
Fixed the code on github, about the menu on even smaller ports will add right after I come back from school.
P.S. didn't upload yet the code to the demo website.