05.01.2015, 10:22
Quote:
|
Originally Posted by Lordzy
 The OPRL used on this script is an old one, I recommend you to use the latest OPRL because it's optimized and has also got an important fix.
Raw source (OPRL3) - https://raw.githubusercontent.com/Lo...ster/OPRL3.inc I just ran through your script and noticed these : 1) The ban functions does not escape reason, which could lead to SQL injection. (This is something that you've to fix ASAP, rather than the suggestions below to improve memory and performance.) 2) You've included foreach, but there are still certain parts where it loops through connected players using normal for-loop. Functions such as "ConnectedPlayers" could return (Iter_Count(Player)) instead. 3) Variables such as "accountMuted" or "accountCMuted" only uses values from 0-1, it could be booleans. Or to save more memory, bit-flagging method can be used. |