11.12.2014, 07:09
I spotted a bug.
You don't kill the timer when the player normally disconnects (OnPlayerDisconnect) by exiting the game, your timer keeps on running for that disconnected player.
If another player connects with the same playerid, there are 2 timers running for that player.
After some time, you've got hundreds of timers running on all players.
It's better to move the KillTimer statement to OnPlayerDisconnect, as that callback also gets called when you ban a player.
Why shouldn't you use OnPlayerUpdate?
That callback only runs for the connected players, so if he's kicked/banned or just leaves, that callback won't be called until the next player connects on that playerid.
No need to create timers and the possible mistake of NOT killing the timer when he disconnects.
Taken from the SAMP wiki:
"This callback is called everytime a client/player updates the server with their status."
A player cannot send updates to the server if he's disconnected, so your server won't get spammed with multiple messages or whatever you do if the jetpack is detected.
For such a simple thing, you could still use OnPlayerUpdate.
You don't kill the timer when the player normally disconnects (OnPlayerDisconnect) by exiting the game, your timer keeps on running for that disconnected player.
If another player connects with the same playerid, there are 2 timers running for that player.
After some time, you've got hundreds of timers running on all players.
It's better to move the KillTimer statement to OnPlayerDisconnect, as that callback also gets called when you ban a player.
Why shouldn't you use OnPlayerUpdate?
That callback only runs for the connected players, so if he's kicked/banned or just leaves, that callback won't be called until the next player connects on that playerid.
No need to create timers and the possible mistake of NOT killing the timer when he disconnects.
Taken from the SAMP wiki:
"This callback is called everytime a client/player updates the server with their status."
A player cannot send updates to the server if he's disconnected, so your server won't get spammed with multiple messages or whatever you do if the jetpack is detected.
For such a simple thing, you could still use OnPlayerUpdate.