11.10.2014, 20:16
lol nice work . Just a few easy suggestions:
- "i" isn't a suitable parameter name since it's mostly used for loops and whatnot. Something like "targetid" would be much better.
- "GetPlayerTargetPlayerEx" is not needed since GetPlayerTargetPlayer returns "INVALID_PLAYER_ID" when the player isn't aiming at anybody.
- "CallLocalFunction" should be used instead of "CallRemoteFunction", so the callback is not called in other loaded scripts.
- "Called" should be static, as it's only used by that script. On another note, some scripts also have a variable named "Called". You should change it to "g_iCalled" (my opinion though).
- "i" isn't a suitable parameter name since it's mostly used for loops and whatnot. Something like "targetid" would be much better.
- "GetPlayerTargetPlayerEx" is not needed since GetPlayerTargetPlayer returns "INVALID_PLAYER_ID" when the player isn't aiming at anybody.
- "CallLocalFunction" should be used instead of "CallRemoteFunction", so the callback is not called in other loaded scripts.
- "Called" should be static, as it's only used by that script. On another note, some scripts also have a variable named "Called". You should change it to "g_iCalled" (my opinion though).