24.02.2014, 15:00
Good effort but there is some serious design dynamic flaws that makes this an absolute nightmare for anyone to try and customize their implementation.
I'll give you some examples.
- Lots of variables that SHOULD be in enums
- Too much code in a single script
- Use of PVars is a huge no-no
- No need to delete playertextdraws when a player disconnects this happens automatically
- This should be a include not a filterscript how is anyone to effectively implement this into a gamemode? Using CallRemoteFunction() and/or PVars is a terrible idea
- No OnPlayerClickTextDraw() so the menu will stay up if you press escape (very annoying), how about when the player dies? Doesn't close either. How about if the player gets shot? That should close the inventory immediately so they can fight
It's a good effort but from my view if I wanted I try and use this there is simply too many problems with this code right now to even give it a try.
I'll give you some examples.
- Lots of variables that SHOULD be in enums
- Too much code in a single script
- Use of PVars is a huge no-no
- No need to delete playertextdraws when a player disconnects this happens automatically
- This should be a include not a filterscript how is anyone to effectively implement this into a gamemode? Using CallRemoteFunction() and/or PVars is a terrible idea
- No OnPlayerClickTextDraw() so the menu will stay up if you press escape (very annoying), how about when the player dies? Doesn't close either. How about if the player gets shot? That should close the inventory immediately so they can fight
It's a good effort but from my view if I wanted I try and use this there is simply too many problems with this code right now to even give it a try.