[Blademaster680]

Make sure that you give them your External IP http://www.whatsmyip.org/
if they are not on the same network as you.
If they are on the same network use cmd and type ipconfig
Make sure that your firewall is not blocking the in-comming connections