25.12.2013, 17:24
Good try. But there are few suggestions.
1. Don't use so many variables, instead do this:
2. Short the usage of so many string variables. You can always use strcat to join with another string.
3. Indentation.
4. #if defined FILTERSCRIPT and #define FILTERSCRIPT, just remove those lines, they're unneeded.
5. Use switch statement for dialogids and listitems.
6. You don't need #pragma unused params. You can also use command like CMD:mycommand(playerid) without params parameter.
There are some more recommendations but I won't be telling them because they aren't really important if you're newbie.
But still good job.
1. Don't use so many variables, instead do this:
pawn Код:
new pNew[10]; // Now you can use pNew[0], pNew[1], pNew[2].....pNew[10] Like that.
3. Indentation.
4. #if defined FILTERSCRIPT and #define FILTERSCRIPT, just remove those lines, they're unneeded.
5. Use switch statement for dialogids and listitems.
6. You don't need #pragma unused params. You can also use command like CMD:mycommand(playerid) without params parameter.
There are some more recommendations but I won't be telling them because they aren't really important if you're newbie.
But still good job.