[jin_zhi]

Quote:

Originally Posted by [uL]Pottus I'm looking at the code for this and I don't really like what I'm seeing, DINI and poor dynamic design the system looks pretty good but I would change this up. 1.) Use sqlite - I recommend https://sampforum.blast.hk/showthread.php?tid=303682 2.) Redesign the dynamic element there should be two functions CreateFurniture() DestroyFurniture() 3.) Use y_iterate to create a custom iterator for your furnature array this is a perfect application 4.) Use zcmd having all your commands in one callback is messy (I don't care even if it's one command do it) 5.) y_inline/y_dialog allows you to integrate dialogs directly into functions (Quick Example) pawn Code: else if(Object_Clear_Click == clickedid)         {             if(CostumeData[playerid][p_CObjectID][CurrCostumeEditSlot[playerid]] != 0)             {                 inline Response(pid, dialogid, response, listitem, string:text[])                 {                     #pragma unused listitem, dialogid, pid, text                     if(response)                     {                         RemoveAttachedObject(playerid, CurrCostumeEditSlot[playerid]);                         PlayerTextDrawSetString(playerid, Object_Info_Player[playerid], "Cleared object from selected slot");                     }                     else PlayerTextDrawSetString(playerid, Object_Info_Player[playerid], "Cancelled clear object");                 }                 Dialog_ShowCallback(playerid, using inline Response, DIALOG_STYLE_MSGBOX, "Costume Editor", "Are you sure you want to clear this object?", "Ok", "Cancel");             }         } Doesn't that look at more natural? Those are my suggestions, otherwise the coding looks fairly decent but if you can make my proposed improvements the system will be much more extensible if someone decides to implement a custom edit and for your own updates.

Thanks for your valuable suggestion.