03.04.2013, 02:09
Doesn't look that great I think here is why.
- You shouldn't have riddled this with PVars they're slow.
- Lots of multiple returns this is a really bad practice and makes convoluted code
- Silly use of foreach()
What the heck are you thinking ?
- Unused callbacks still in the script why?
- OnDialogResponse() using a series of if()'s use a switch
- Lots of copy paste code that could easily be condensed
- Should be an include that can be compiled into a gamemode
It is a good effort but the code is really messy and really ugly unusable in my books I'm sorry if you don't like my comments but I'd rather be honest than say "Amazing" or some nonsense like these other guys who can't even analyze code worth a damn.
- You shouldn't have riddled this with PVars they're slow.
- Lots of multiple returns this is a really bad practice and makes convoluted code
- Silly use of foreach()
What the heck are you thinking ?
Код:
foreach(Player, i) { if(IsPlayerConnected(i) }
- OnDialogResponse() using a series of if()'s use a switch
- Lots of copy paste code that could easily be condensed
- Should be an include that can be compiled into a gamemode
It is a good effort but the code is really messy and really ugly unusable in my books I'm sorry if you don't like my comments but I'd rather be honest than say "Amazing" or some nonsense like these other guys who can't even analyze code worth a damn.