Quick Help - Invalid Skin
#2

Well you should indent better, it makes reading errors easier. But you should also look into dcmd and sscanf. They are faster and a lot easier.

pawn Код:
dcmd_setskin(playerid,params[])
{
    new player, skin;
    if(sscanf(params,"dd",player,skin))
    {
        SendClientMessage(playerid, COLOR_WHITE, "USAGE: /setskin [playerid] [skinid]");
        return 1;
    }
    if(!IsPlayerConnected(player))
    {
        SendClientMessage(playerid, COLOR_WHITE, "Invalid Player ID.");
        return 1;
    }
    if(IsInvalidSkin(skin))
    {
        SendClientMessage(playerid, COLOR_GREY, "* Invalid Skin ID");
        return 1;
    }
    SetPlayerSkin(player, skin);
    SendClientMessage(player, COLOR_WHITE, "An Admin has changed your skin.");
    return 1;
}
Or even less. Although, I hate when people code like this.

pawn Код:
dcmd_setskin(playerid,params[])
{
    new player, skin;
    if(sscanf(params,"dd",player,skin)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /setskin [playerid] [skinid]");
    if(!IsPlayerConnected(player)) return SendClientMessage(playerid, COLOR_WHITE, "Invalid Player ID.");
    if(IsInvalidSkin(skin)) return SendClientMessage(playerid, COLOR_GREY, "* Invalid Skin ID");
    SetPlayerSkin(player, skin);
    SendClientMessage(player, COLOR_WHITE, "An Admin has changed your skin.");
    return 1;
}
Reply


Messages In This Thread
Quick Help - Invalid Skin - by member - 15.02.2009, 16:27
Re: Quick Help - Invalid Skin - by Backwardsman97 - 15.02.2009, 16:49
[SOLVED] Quick Help - Invalid Skin - by member - 15.02.2009, 17:07

Forum Jump:


Users browsing this thread: 1 Guest(s)