Vulnerabilities on receiving null commands
#19

Quote:
Originally Posted by kurta999
View Post
This not fixed.

pawn Code:
public OnFilterScriptInit()
{
    new empty[16];//not assigning a string, then it is null. If formatting it as "" it will add the /0 character to the first byte

    CallLocalFunction("test","s",empty);//afaik print doesn't crash with empty strings, calllocalfunction does
    return 1;
}

forward test(aaa[]);
public test(aaa[])
{
    print(aaa);
    return 1;
}
That has been a problem for a very long time. It can be easily fixed by adding an isnull check before CallLocal/RemoteFunction. What I talk about here is that cheaters can send 0-length command (even without the slash) to the server, causing weird crashes.

As far as we discussed here, such attack can be easily blocked by insull check before processing your commands. I even made it to ban the cheater if the command checked is null. I tested my script with similar empty command hacks that can be easily found, and it successfully blocks the attack.

It is good if it is fixed in 0.3x, but I think we can't detect if anybody try to attack the server.
Reply


Messages In This Thread
Vulnerabilities on receiving null commands - by leong124 - 22.12.2012, 08:31
Re: Vulnerabilities on receiving null commands - by ev0lution - 22.12.2012, 09:18
Re: Vulnerabilities on receiving null commands - by AndreT - 22.12.2012, 09:24
Re: Vulnerabilities on receiving null commands - by leong124 - 22.12.2012, 09:32
Re: Vulnerabilities on receiving null commands - by ev0lution - 22.12.2012, 09:59
Re: Vulnerabilities on receiving null commands - by Kar - 23.12.2012, 04:22
Re: Vulnerabilities on receiving null commands - by Lorenc_ - 23.12.2012, 07:17
Re: Vulnerabilities on receiving null commands - by leong124 - 26.12.2012, 18:42
Respuesta: Vulnerabilities on receiving null commands - by Jupit3r - 27.12.2012, 12:20
Re: Vulnerabilities on receiving null commands - by Lorenc_ - 27.12.2012, 22:52
Re: Vulnerabilities on receiving null commands - by leong124 - 28.12.2012, 08:16
Re: Vulnerabilities on receiving null commands - by ikkentim - 05.01.2013, 10:00
Re: Vulnerabilities on receiving null commands - by leong124 - 05.01.2013, 11:46
Re: Vulnerabilities on receiving null commands - by mastermax7777 - 06.01.2013, 04:10
Re: Vulnerabilities on receiving null commands - by leong124 - 06.01.2013, 14:19
Re: Vulnerabilities on receiving null commands - by Karlip - 08.01.2013, 15:47
Re: Vulnerabilities on receiving null commands - by leong124 - 08.01.2013, 19:30
Re: Vulnerabilities on receiving null commands - by kurta999 - 08.01.2013, 20:23
Re: Vulnerabilities on receiving null commands - by leong124 - 09.01.2013, 08:06

Forum Jump:


Users browsing this thread: 4 Guest(s)