08.12.2012, 12:34
Quote:
1. Sure there are a lot of variables but it has the exact same result as using an enum. All the variables are optimised and I really don't see why this would be an issue.
2. MySQL isn't needed in a server that does not plan to use website integration. MySQL is quite overkill for a small servers anyway. SQLite would be pretty cool in this sort of gamemode but it's not really any slower or less efficient with files. 3. The checkpoints could have used incognitos but I don't really think that it matters too much. This is probably one of the only floors in the code and it could have been improved if he simply just changed a couple of functions. You don't really need an object streamer when you are not going to use the MAX object limit so that doesn't really matter. I wouldn't have released this for him if I didn't think it looked good. The code could have been made shorter but there are not too many points that could have been improved to make the gamemode more efficient. Anyone can critique each others code but I wouldn't put it as far as saying it's shoddy. |
Going back onto the variables, rather than having 500 variables, it just looks alot more tidier with enums and start to have dynamic stores, houses etc rather than having to have lots of variables for robberies etc when it can be done in one variable when it's dynamic..
As for MySQL, MySQL isn't overkill at all. I use it for my gamemode due to the flexibility and capability of it. Yes, my server isn't a 30+ player server but at least it is capable of handling that many players in the future.
I didn't say it wasn't a good free release but if it was sold I wouldn't be too happy with this. Infact, I'm not calling the release shoddy, just his way of work. Especially how it could of been tidied up alot.