Quote:
Originally Posted by AndreT
Also, I see something like this:
pawn Код:
// Definition new g_Logged[MAX_PLAYERS char];
// Changing it g_Logged[playerid] = 0;
Question is: does that really work? I think I remember that the last time I accessed a "char"-array using square brackets, the results were not as expected... For the sake of understanding though, shouldn't it be
|
I honestly had no clue, thanks for clearing that up for me.
Quote:
Originally Posted by AndreT
Also you probably assumed it is my best intention to complain things like this:
pawn Код:
`interior` int(11) NOT NULL, \ // ... `skin` int(11) NOT NULL, \
As far as I know, valid interior IDs are 0 to 19 and valid skin IDs are 0 to 299. Your field type however would allow much lengthier values and even though you don't populate the fields with larger values, a larger amount of space will be used to store the values. Refer to this.
A suitable field type for `interior` would even be TINYINT(2) and for `skin`, SMALLINT(3) will do perfectly. Some space hopefully saved!
|
This is also skipped my mind. Perhaps I should have been sure on a couple of more things before releasing this. Anyways, thanks for your critique. Main post has been updated with links to the scripts with the aforementioned changes.