[Y_Less]

Quote:

Originally Posted by Jonny5 1.) did not even think about this, Great idea and will be added! Do you think having having it load the custom Callbacks from files would be better? I could load for each Lib, and have a file for new SAMP callbacks, that could be added to until I make official update. This way I could write simple list file for each to support YSI, Streamer ect... I think I may go that route.

Yeah, that might be a better route for multiple ones.

Quote:

Originally Posted by Jonny5 2.) this does no checks, it just creates a skeleton ALS function for you, I assume the scripter will handle any checks, but If its something I can add I defiantly will. If you can post an example of what you mean that would be great.

OnPlayerDialogResponse is the main culprit for this:

pawn Code:

return CallLocalFunction("Prefix_OnDialogResponse", "iiiis",playerid, dialogid, response, listitem, inputtext);

If they didn't type anything in (say on a message box), this will actually crash. Instead you need:

pawn Code:

return CallLocalFunction("Prefix_OnDialogResponse", "iiiis",playerid, dialogid, response, listitem, inputtext[0] ? inputtext : "\1\0");

Where "\1\0" is the standard "almost" empty string used when an empty string can't, but should, be used. I'm not sure if it's possible to call the other string callbacks with an empty string, but I always do the checks incase some hack tool manages to send an empty chat message or something similar.

Quote:

Originally Posted by Jonny5 3.) I thought doing it this way would return the next callbacks return, I will go back and re-read! EDIT: I see the only advantage is OnGameModeInit() I will fix this. 4.)Yes you are correct! I will make that change, Nice ideas!! and thanks for the tips, I will implement them ASAP.

Cool, no problem.