[Tool/Web/Other] GetHighestNumber
#5

It's nice. And was it my "GetPlayerWithHighestScore" you've seen? :P (-.-)
However, in my function (GetPlayerWithHighestScore) I use 'cellmin' instead of 0. What is the integer is a '-' value?
Here's an example with your function:

pawn Код:
#include <a_samp>

public OnFilterScriptInit()
    return printf("%d", GetHighestNumber(-1, -5, -9, -3));
Which will return '0', because:
Код:
highestyet = 0;
if(-1 > 0) highestyet = -1. FALSE: highestyet stays 0;
if(-5 > 0) highestyet = -5. FALSE: highestyet stays 0;
if(-9 > 0) highestyet = -9. FALSE: highestyet stays 0;
if(-3 > 0) highestyet = -3; FALSE: highestyet stays 0;
return highestyet = 0;
You see what I mean?
I recommend you to change 'highestyet = 0' to 'highestyet = cellmin', so:
pawn Код:
stock GetHighestNumber(...)
{
    new args = numargs();
    new highestyet = cellmin;
    for (new i = 0; i<args; i++)
    {
        if (getarg(i,0) > highestyet) highestyet = getarg(i,0);
    }
    return highestyet;
}
Also, I wouldn't use brackets for one single line after a for statement (optional).
pawn Код:
for (new i = 0; i<args; i++)
    if (getarg(i,0) > highestyet) highestyet = getarg(i,0);
And with the 'new' I would use komma's :P (I'm annoying now aren't I). + why using 'new args = numargs()', you could just use 'numargs' in the loop.
pawn Код:
stock GetHighestNumber(...)
{
    new highestyet = cellmin;
    for(new i = 0; i < numargs(); i++)
        if(getarg(i) > highestyet) highestyet = getarg(i);
    return highestyet;
}
However, sorry for annoying (again :P). But the first thing I've said is quite important for such a function as this.

- Kevin
Reply


Messages In This Thread
GetHighestNumber - by DeadAhead - 25.04.2011, 18:54
Re: GetHighestNumber - by Hiddos - 25.04.2011, 19:08
Re: GetHighestNumber - by DeadAhead - 25.04.2011, 19:09
Re: GetHighestNumber - by Unknown1234 - 25.04.2011, 19:43
Re: GetHighestNumber - by Kwarde - 25.04.2011, 20:03
Re: GetHighestNumber - by RyDeR` - 25.04.2011, 20:06
Re: GetHighestNumber - by Kwarde - 25.04.2011, 20:07
AW: GetHighestNumber - by [DR]Reaper[GEARS] - 25.04.2011, 20:20

Forum Jump:


Users browsing this thread: 1 Guest(s)