Quote:
Originally Posted by maramizo
There really was no reed to write all that... Lol.
@OP :
If you use "else", you shouldn't really be using return 1; at the end, because ELSE includes EVERYTHING other than the IF earlier stated.
|
Why not? Obviously he doesn't know what the error means, so instead of providing him with a quick fix, why not explain to him what the error means, and then he can fix it himself and learn something new? Then he won't have to rely on other people to solve it for him in the future if it happens again.
Quote:
Originally Posted by Schurman
pawn Код:
if(!strcmp(cmd, "/kick")
{
if(!IsPlayerAdmin(playerid)) return SendClientMessage(playerid,0xFFFFFFFF,"You are not an admin !");
new targetid, reason[64], string[128];
if(sscanf(params, "uz", targetid, reason)) return SendClientMessage(playerid, 0xFFFFFFFF, "Usage: /kick [playerid/partofname] [reason]");
if(!IsPlayerConnected(targetid))
{
SendClientMessage(playerid,0xFFFFFFFF,"Player not connected!");
}
else
{
new pName[128];
GetPlayerName(targetid,pName,128);
format(string, sizeof(string), "%s have been Muted By an Admin ! Reason: %s", pName, reason);
SendClientMessageToAll(0xA10000AA,string);
format(string, sizeof(string), "You have been kicked! Reason: %s", reason);
SendClientMessage(targetid,0xA10000AA,string);
Kick(targetid);
return 1;
}
}
|
There's a problem with that structure too, should the player not be connected, the code will continue down past the command. So I would suggest putting the return 1 outside of the else statement. Like so:
pawn Код:
if(!strcmp(cmd, "/kick")
{
if(!IsPlayerAdmin(playerid)) return SendClientMessage(playerid,0xFFFFFFFF,"You are not an admin !");
new targetid, reason[64], string[128];
if(sscanf(params, "uz", targetid, reason)) return SendClientMessage(playerid, 0xFFFFFFFF, "Usage: /kick [playerid/partofname] [reason]");
if(!IsPlayerConnected(targetid))
{
SendClientMessage(playerid,0xFFFFFFFF,"Player not connected!");
}
else
{
new pName[128];
GetPlayerName(targetid,pName,128);
format(string, sizeof(string), "%s have been Muted By an Admin ! Reason: %s", pName, reason);
SendClientMessageToAll(0xA10000AA,string);
format(string, sizeof(string), "You have been kicked! Reason: %s", reason);
SendClientMessage(targetid,0xA10000AA,string);
Kick(targetid);
}
return 1;
}
