[YungGee]

I have created(Tried to create) my first simple "Anti-Weapon-Hacks" script just using my knowledge i have so far.

May i ask for some answers on how i can better my code more efficiently while keeping in mind it has not been tested.

Its a simple code im sure works but id like to be shown how to make it "Better" or faster please.

pawn Код:

//Anti-Weapon-Hax Test
#include <a_samp>

#define FILTERSCRIPT

new bool:Banable[MAX_PLAYERS];

forward BanHacker();
forward SearchForWeaponHackers();

public OnFilterScriptInit()
{
    SetTimer("SearchForWeaponHackers",2000,true);
    return 1;
}

public OnFilterScriptExit()
{
    return 1;
}

public OnPlayerConnect(playerid)
{
    Banable[playerid] = false;
    return 1;
}


public SearchForWeaponHackers()
{
    for (new i = 0; i < MAX_PLAYERS; i++)
    {
        if (GetPlayerWeapon(i) == 9 || GetPlayerWeapon(i) == 16 || GetPlayerWeapon(i) == 18 || GetPlayerWeapon(i) == 35  || GetPlayerWeapon(i) == 36 || GetPlayerWeapon(i) == 37 || GetPlayerWeapon(i) == 38)
        {
            new pName[24];
            new string[128];
            GetPlayerName(i, pName, sizeof(pName));
            format(string, sizeof(string), ">> %s [%d] Has Been Banned From The Server! Reason: Weapon Hacks", pName,i);
            SendClientMessageToAll(0xFF0000AA,string);
            SetTimer("BanWeaponHacker",200,false);
            Banable[i] = true;
        }
        else
        {
            Banable[i] = false;
        }
    }
}

public BanHacker()
{
    for (new i = 0; i < MAX_PLAYERS; i++)
    {
        if(Banable[i] == true)
        {
            BanEx(i,"Weapon Hacks");
        }
    }
}

Thank you,