Quote:
Originally Posted by Paulice
PHP Code:
for(new i = 0; i < GetMaxPlayers(); i++) // looping through connected players
GetPlayerPoolSize exists, use it (note: making it a plug n\' play script for any "SA-MP version" is not a valid excuse to not use the relatively new function)! |
EDIT: Good Point, i was doing it wrrong
Quote:
Originally Posted by Paulice
PHP Code:
for(new i = 0; i < 4; i++) // new PlayerText:p_Speedo[MAX_PLAYERS][4];
for(new i = 0; i < 18; i++) // new Text:g_Speedo[18];
Have you never heard of "sizeof"? |
Yes i did heared of it. but in this case its constant. so there no need to wast more ms for a const var.
Quote:
Originally Posted by Paulice
PHP Code:
new speed;
speed = GetPlayerSpeed(playerid);
Can you not do "new speed = GetPlayerSpeed(playerid);"? |
This is under scripter style. its doesn\'t matter in this point. but declaring variable before setting the var is better.
Quote:
Originally Posted by Paulice
PHP Code:
if(speed == 0)
{
}
else
{
if(speed > 0) Gear[playerid] = "D";
}
The second if-then is useless. Speed will obviously always be over 0 (note: there\'s no negative speed)!
-_- |
if you did notice. i did used "else" without specifing what it should it check. 1 line for checking doesn\'t matter. also its gonna be checked anyway if you do or not, Gear "D" need to be attached.
Quote:
Originally Posted by Paulice
PHP Code:
if(speed > 0) Gear[playerid] = "D";
if(IsVehicleDrivingBackwards(GetPlayerVehicleID(playerid))) Gear[playerid] = "R";
Have you never heard of "else if"? Guess not. |
i did heared of it too! but the speed is always positive, so if i used "else" the script won\'t count the reserve gear.
Quote:
Originally Posted by Paulice
PHP Code:
if(speed > 200) speed = 205;
Your system supports up to 200. By setting it to 205 when it\'s over 200 tells us either the representation is inaccurate or you know what. |
after i did counted x and y, i did found after 195 the arrow miss 2.0 of x. so i did added 5 to make it right on 200! also the max of speed is 210
Quote:
Originally Posted by Paulice
https://cdn.discordapp.com/attachmen.../sa-mp-087.png
- Speed will never go over 999, the extra zero (0) in "0099 KM/H" is useless.
- "Test Server Name" is not centered.
- The alignment of the bar is terrible and inaccurate.
- I have no idea why "Gear:" is in a different font than the speed.
- The number in the middle is just horrendous.
|
- Helicopters goes more than 999km/h
- Finally you did find something useful. i will edit on next update!
- that your opinion, thanks
- Because its Gear. on real cars Gear haven\'ts same font as speed counter.
- Nice to know.
Quote:
Originally Posted by Paulice
Overall, 2 stars. And I don\'t see why you feel the need to reply "thanks" or "thank you" to every positive post.
|
Thanks for feedback.
Note: god fathers alraedy checked the script before it goes released. i did worked hard to make opitimzed and clean. their opinion was +4 reps from everyone. and they confirmed to me that\'s a clean script.
Can\'t you stop being like that SickAttack?
Quote:
Originally Posted by Mr.Vince™
Can I Change Position Of Speedmeter To center of the screen
|
Yes you can you need only to minus the x values from the real positions
401.etc - 10.0 per textdraw
