[NeXoR]

Hey guys, this is a mysql CMD to retrieve all registered accounts on an IP address, do you have any suggestions to make it faster & more efficient ?

PHP код:

CMD:checkalts(playerid, params[])
{
    if(!IsAllowed(playerid, 3)) return NoAuth(playerid);
    new playerb;
    if(sscanf(params, "u", playerb)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /checkalts [playerid]");
    if(!IsPlayerConnected(playerb)) return SendClientMessage(playerid, COLOR_WHITE, "Invalid ID.");
    if(IsImmune(playerid, playerb)) return NotImmune(playerid);
    new query[128], Cache:result, rows, tempname[24], tempdate[12];
    mysql_format(mysql, query, sizeof(query), "SELECT `Username`, `Score`, `Registration` FROM `Users` WHERE `IP`='%s' ORDER BY `UserID`", RPIP(playerb));
    result = mysql_query(mysql, query);
    rows = cache_get_row_count(mysql);
    format(query, sizeof(query), "Active & Registered accounts on %s.", RPIP(playerb));
    SendClientMessage(playerid, COLOR_REPORT, query);
    if(rows)
    {
        for(new i = 0; i < rows; i++)
        {
            cache_get_field_content(i, "Username", tempname, mysql, sizeof(tempname));
            cache_get_field_content(i, "Registration", tempdate, mysql, sizeof(tempdate));
            format(query, sizeof(query), "Username: %s || Registration Date: %s || Score: %d", tempname, tempdate, cache_get_field_content_int(i, "Score"));
            SendClientMessage(playerid, COLOR_RED, query);
        }
    }
    cache_delete(result);
    return 1;
} 


[oMa37]

Check if the player is INVALID_PLAYER_ID instead of checking if the player is not connected.
Don't use SendClientMessage inside the loop.
You don't need to use sizeof in the cache_get.., It basically get the sizeof the destination. ( max_len = sizeof(destination)).

PHP код:

CMD:checkalts(playerid, params[])
{
    if(!IsAllowed(playerid, 3)) return NoAuth(playerid);
    new playerb;
    if(sscanf(params, "u", playerb)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /checkalts [playerid]");
    if(playerb == INVALID_PLAYER_ID) return SendClientMessage(playerid, COLOR_WHITE, "Invalid ID.");
    if(IsImmune(playerid, playerb)) return NotImmune(playerid);
    new query[128], Cache:result, tempname[24], tempdate[12];
    mysql_format(mysql, query, sizeof(query), "SELECT `Username`, `Score`, `Registration` FROM `Users` WHERE `IP` = '%s' ORDER BY `UserID`", RPIP(playerb));
    result = mysql_query(mysql, query);
    new rows = cache_num_rows();
    format(query, sizeof(query), "Active & Registered accounts on %s.", RPIP(playerb));
    SendClientMessage(playerid, COLOR_REPORT, query);
    if(rows)
    {
        for(new i; i < rows; i++)
        {
            cache_get_field_content(i, "Username", tempname); // use the connection handle if you have option DUPLICATE_CONNECTION
            cache_get_field_content(i, "Registration", tempdate);  // use the connection handle if you have option DUPLICATE_CONNECTION
            format(query, sizeof(query), "Username: %s || Registration Date: %s || Score: %d", tempname, tempdate, cache_get_field_content_int(i, "Score"));
        }
        SendClientMessage(playerid, COLOR_RED, query);
    }
    cache_delete(result);
    return 1;
} 


I think it's good now.

[NeXoR]

Quote:

Originally Posted by oMa37 Check if the player is INVALID_PLAYER_ID instead of checking if the player is not connected. Don't use SendClientMessage inside the loop. You don't need to use sizeof in the cache_get.., It basically get the sizeof the destination. ( max_len = sizeof(destination)). PHP код: CMD:checkalts(playerid, params[]) {     if(!IsAllowed(playerid, 3)) return NoAuth(playerid);     new playerb;     if(sscanf(params, "u", playerb)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /checkalts [playerid]");     if(playerb == INVALID_PLAYER_ID) return SendClientMessage(playerid, COLOR_WHITE, "Invalid ID.");     if(IsImmune(playerid, playerb)) return NotImmune(playerid);     new query[128], Cache:result, tempname[24], tempdate[12];     mysql_format(mysql, query, sizeof(query), "SELECT `Username`, `Score`, `Registration` FROM `Users` WHERE `IP` = '%s' ORDER BY `UserID`", RPIP(playerb));     result = mysql_query(mysql, query);     new rows = cache_num_rows();     format(query, sizeof(query), "Active & Registered accounts on %s.", RPIP(playerb));     SendClientMessage(playerid, COLOR_REPORT, query);     if(rows)     {         for(new i; i < rows; i++)         {             cache_get_field_content(i, "Username", tempname); // use the connection handle if you have option DUPLICATE_CONNECTION             cache_get_field_content(i, "Registration", tempdate);  // use the connection handle if you have option DUPLICATE_CONNECTION             format(query, sizeof(query), "Username: %s || Registration Date: %s || Score: %d", tempname, tempdate, cache_get_field_content_int(i, "Score"));         }         SendClientMessage(playerid, COLOR_RED, query);     }     cache_delete(result);     return 1; }  I think it's good now.

Actually I have to, since I want to present ALL the accounts on the same IP.
Thanks for the INVALID PLAYER ID tip, are you sure it should work and not fuck up the system ?

[oMa37]

Quote:

Originally Posted by NeXoR Thanks for the INVALID PLAYER ID tip, are you sure it should work and not fuck up the system ?

INVALID_PLAYER_ID means the ID is not exists, which means the player is not connected, so yeah it wont screw up anything.

[Threshold]

Then why not just use !IsPlayerConnected? What if somehow the player ID is 10 and player ID 10 isn't connected? Then your logic fails. IsPlayerConnected works for existing AND invalid IDs, I think the original method was fine.

EDIT: I thought you said IsPlayerConnected wouldn't work in this situation. Either you edited it or I completely misread it.

[oMa37]

Checking if target ID is INVALID_PLAYER_ID is much better than calling IsPlayerConnected function.

[AndySedeyn]

SSCANF searches for the player with the specified ID/name (only with 'u', 'q' and 'r'). So, checking it against a constant value IS more efficient. Moreover, doing the search again with IsPlayerConnected is redundant and basically means repetitive code which should be avoided at all times.

[Threshold]

Yes, I'm aware of that. Lol.