1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help
  4. Help Archive

Threaded Mode
/playerlist Only one players shows up ;/
Moron
Big Clucker
***
Posts: 76
Threads: 28
Joined: May 2011
Reputation: 0
#1

06.07.2011, 16:59
I was making a command to show players for a specific group and i wanted to test it on NPC's, but only one of 4 NPC's show up ;/

Код:
    if(!strcmp(cmdtext, "/testing", true))
	{
	new name[MAX_PLAYER_NAME];
	for(new i = 0; i <MAX_PLAYERS; i++){
	if(IsPlayerNPC(i)){
	new lol[256] = "* ";

	GetPlayerName(i,name,MAX_PLAYER_NAME);
	format(lol,256,"{FFFFFF}%s {64B500}%s,",lol,name);
	ShowPlayerDialog(playerid,100,DIALOG_STYLE_MSGBOX,"{64B500}Online:",lol,"OK","Exit");
	}
	}
	return 1;
	}
Find
Reply
Moron
Big Clucker
***
Posts: 76
Threads: 28
Joined: May 2011
Reputation: 0
#2

06.07.2011, 17:47
Oh yes if i change the GUI with
Код:
SendClientMessage(playerid,COLOR_BLUE,lol);
it works fine, but i still need GUI ;/ HELP
Find
Reply
Shadoww5
High-roller
*****
Posts: 2,197
Threads: 25
Joined: Apr 2011
Reputation: 0
#3

06.07.2011, 19:00
What is this ? o.O

PHP код:
new lol[256] = "* "; 
Find
Reply
Donya
Gangsta
****
Posts: 715
Threads: 47
Joined: Mar 2011
Reputation: 0
#4

06.07.2011, 19:05
pawn Код:
if(!strcmp(cmdtext, "/testing", true))
{
    new name[MAX_PLAYER_NAME], lol[256] = "* ";
    for(new i = 0; i <MAX_PLAYERS; i++)
    {
        if(IsPlayerNPC(i)) continue;
        GetPlayerName(i,name,MAX_PLAYER_NAME);
        format(lol, 256, "{FFFFFF}%s {64B500}%s,", lol, name);
    }
    ShowPlayerDialog(playerid,100,DIALOG_STYLE_MSGBOX,"{64B500}Online:",lol,"OK","Exit");
    return 1;
}
Find
Reply
Shadoww5
High-roller
*****
Posts: 2,197
Threads: 25
Joined: Apr 2011
Reputation: 0
#5

06.07.2011, 19:12
( Последний раз редактировалось Shadoww5; 06.07.2011 в 20:01. )
PHP код:
if(!strcmp(cmdtext, "/testing", true))
{
    new name[MAX_PLAYER_NAME], lol[256], string[80];
    for(new i = 0; i <MAX_PLAYERS; i++)
    {
        if(!IsPlayerNPC(i)) continue;
        GetPlayerName(i, name, MAX_PLAYER_NAME);
        format(string, sizeof string,"{FFFFFF}%d {64B500}%s,", i, name);
        strcat(lol,string);
    }
    ShowPlayerDialog(playerid,100,DIALOG_STYLE_MSGBOX,"{64B500}Online:",lol,"OK","Exit");
    return 1;
} 
Find
Reply
Donya
Gangsta
****
Posts: 715
Threads: 47
Joined: Mar 2011
Reputation: 0
#6

06.07.2011, 19:46
Quote:
Originally Posted by Shadoww5
Посмотреть сообщение
PHP код:
if(!strcmp(cmdtext, "/testing", true))
{
    new name[MAX_PLAYER_NAME], lol[256];
    for(new i = 0; i <MAX_PLAYERS; i++)
    {
        if(!IsPlayerNPC(i)) continue;
        GetPlayerName(i,name,MAX_PLAYER_NAME);
        strcat(lol,"{FFFFFF}%s {64B500}%s,",i,name);
    }
    ShowPlayerDialog(playerid,100,DIALOG_STYLE_MSGBOX,"{64B500}Online:",lol,"OK","Exit");
    return 1;
} 
you cant do strcat(lol,"{FFFFFF}%s {64B500}%s,",i,name);

so either way, mine would be the working one and the fastest.. cus if u do format then strcat = slower..
Find
Reply
Shadoww5
High-roller
*****
Posts: 2,197
Threads: 25
Joined: Apr 2011
Reputation: 0
#7

06.07.2011, 19:52
Oh sorry !

Now it's correct:

PHP код:
if(!strcmp(cmdtext, "/testing", true))
{
    new name[MAX_PLAYER_NAME], lol[256], string[80];
    for(new i = 0; i <MAX_PLAYERS; i++)
    {
        if(!IsPlayerNPC(i)) continue;
        GetPlayerName(i, name, MAX_PLAYER_NAME);
        format(string, sizeof string, "{FFFFFF}%d {64B500}%s,", i, name);
        strcat(lol,string);
    }
    ShowPlayerDialog(playerid,100,DIALOG_STYLE_MSGBOX,"{64B500}Online:",lol,"OK","Exit");
    return 1;
} 
Find
Reply
Ricop522
High-roller
*****
Posts: 2,640
Threads: 122
Joined: Feb 2010
Reputation: 0
#8

06.07.2011, 19:55
Test this..
PHP код:
    if(strcmp(cmd, "/testing", true) == 0) //by Ricop522
    {
        new playersonline[500], playersonline2[504];
        new plName[MAX_PLAYER_NAME], Ricop522  = 0;
        for( ; Ricop522 < MAX_PLAYERS; ++Ricop522)
        {
            if(IsPlayerConnected(i)) {
                GetPlayerName(i, plName, sizeof(plName));
                format(playersonline, sizeof(playersonline), "{FFFFFF}%i {64B500}%s\n", Ricop522, plName);
                strcat(playersonline2,playersonline);
            }
        }
        ShowPlayerDialog(playerid,100,DIALOG_STYLE_LIST,"Players On",playersonline2,"Exit","");
        return 0x01;
    } 
Find
Reply
Donya
Gangsta
****
Posts: 715
Threads: 47
Joined: Mar 2011
Reputation: 0
#9

06.07.2011, 20:00
omg.. did u people not read my post.. and why are you people using the php code tag..
Find
Reply
TheGarfield
Banned
Posts: 649
Threads: 4
Joined: Jul 2010
#10

06.07.2011, 20:00
Quote:
Originally Posted by Ricop522
Посмотреть сообщение
Test this..
PHP код:
    if(strcmp(cmd, "/testing", true) == 0) //by Ricop522
    {
        new playersonline[500], playersonline2[504];
        static plName[MAX_PLAYER_NAME], Ricop522  = 0;
        for( ; Ricop522 < MAX_PLAYERS; ++Ricop522)
        {
            if(IsPlayerConnected(i)) {
                GetPlayerName(i, plName, sizeof(plName));
                format(playersonline, sizeof(playersonline), "{FFFFFF}%i {64B500}%s\n", Ricop522, plName);
                strcat(playersonline2,playersonline);
            }
        }
        ShowPlayerDialog(playerid,100,DIALOG_STYLE_LIST,"Players On",playersonline2,"Exit","");
        return 0x01;
    } 
you can't use variables statics in loops and appers error: Undefined Symbol "i"

pawn Код:
if(strcmp(cmd, "/testing", true) == 0) //by Garfield
    {
        new playersonline[500], playersonline2[MAX_PLAYERS*2];
        new plName[MAX_PLAYER_NAME];
        for(new i ; i < MAX_PLAYERS; ++i)
        {
            if(IsPlayerConnected(i ))
            {
                GetPlayerName(i, plName, sizeof(plName));
                format(playersonline, sizeof(playersonline), "{FFFFFF}%i {64B500}%s\n", i, plName);
                strcat(playersonline2,playersonline);
            }
        }
        ShowPlayerDialog(playerid,100,DIALOG_STYLE_LIST,"Players On",playersonline2,"Exit","");
        return 1;
    }
[...]
Find
Reply
Ricop522
High-roller
*****
Posts: 2,640
Threads: 122
Joined: Feb 2010
Reputation: 0
#11

06.07.2011, 20:11
I say:
"I think this works."

I retired this from my gamemode, the /list of the cars .
You just copy my code and remove a little things.


Att, Ricop522.
Find
Reply
Donya
Gangsta
****
Posts: 715
Threads: 47
Joined: Mar 2011
Reputation: 0
#12

06.07.2011, 20:17
Quote:
Originally Posted by Ricop522
Посмотреть сообщение
I say:
"I think this works."

I retired this from my gamemode, the /list of the cars .
You just copy my code and remove a little things.


Att, Ricop522.
he fixed it. your code would've actually returned an error.

Quote:
Originally Posted by Donya
Посмотреть сообщение
pawn Код:
if(!strcmp(cmdtext, "/testing", true))
{
    new name[MAX_PLAYER_NAME], lol[256] = "* ";
    for(new i = 0; i <MAX_PLAYERS; i++)
    {
        if(IsPlayerNPC(i)) continue;
        GetPlayerName(i,name,MAX_PLAYER_NAME);
        format(lol, 256, "{FFFFFF}%s {64B500}%s,", lol, name);
    }
    ShowPlayerDialog(playerid,100,DIALOG_STYLE_MSGBOX,"{64B500}Online:",lol,"OK","Exit");
    return 1;
}
Find
Reply
BigETI
Banned
Posts: 1,046
Threads: 29
Joined: Mar 2010
#13

06.07.2011, 20:40
I gonna clear up these things:
pawn Код:
if(!strcmp(cmdtext, "/testing", true))
{
    new bool:check = false, lol[1024] = "* ";
    for(new i = 0; i < MAX_PLAYERS; i++)
    {
        if(IsPlayerConnected(i) && IsPlayerNPC(i)) //You can add here another checks later.
        {
            new name[MAX_PLAYER_NAME];
            GetPlayerName(i, name, sizeof(name));
            if(!check)
            {
                format(lol, sizeof(lol), "{FFFFFF}%s {64B500}%s", lol, name);
                state = true;
            }
            else format(lol, sizeof(lol),"%s, %s", lol, name);
        }
    }
    if(check) ShowPlayerDialog(playerid, 100, DIALOG_STYLE_MSGBOX, "{64B500}Online:", lol, "OK", "Exit");
    else ShowPlayerDialog(playerid, 100, DIALOG_STYLE_MSGBOX, "{64B500}Online:", "{FF0000}Nobody", "OK", "Exit");
    return 1;
}
Find
Reply
Shadoww5
High-roller
*****
Posts: 2,197
Threads: 25
Joined: Apr 2011
Reputation: 0
#14

06.07.2011, 23:17
Quote:
Originally Posted by BigETI
Посмотреть сообщение
I gonna clear up these things:
pawn Код:
if(!strcmp(cmdtext, "/testing", true))
{
    new bool:check = false, lol[1024] = "* ";
    for(new i = 0; i < MAX_PLAYERS; i++)
    {
        if(IsPlayerConnected(i) && IsPlayerNPC(i)) //You can add here another checks later.
        {
            new name[MAX_PLAYER_NAME];
            GetPlayerName(i, name, sizeof(name));
            if(!check)
            {
                format(lol, sizeof(lol), "{FFFFFF}%s {64B500}%s", lol, name);
                state = true;
            }
            else format(lol, sizeof(lol),"%s, %s", lol, name);
        }
    }
    if(check) ShowPlayerDialog(playerid, 100, DIALOG_STYLE_MSGBOX, "{64B500}Online:", lol, "OK", "Exit");
    else ShowPlayerDialog(playerid, 100, DIALOG_STYLE_MSGBOX, "{64B500}Online:", "{FF0000}Nobody", "OK", "Exit");
    return 1;
}
No need to do all this.
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 2 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help
  4. Help Archive