[GBLTeam]

So i change everycars without (IDS) btw now i have problem with rentbike. Whats wrong why this bikes is not for rent?



Bikes:

pawn Код:

SPAWN1 = AddStaticVehicleEx(462,805.32794189,-1344.44934082,13.21709442,62.00000000,2,1,15); //Faggio
    SPAWN2 = AddStaticVehicleEx(462,805.19195557,-1342.43786621,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN3 = AddStaticVehicleEx(462,805.06109619,-1340.42614746,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN4 = AddStaticVehicleEx(462,805.34625244,-1338.56909180,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN5 = AddStaticVehicleEx(462,805.31506348,-1348.18957520,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN6 = AddStaticVehicleEx(462,805.31738281,-1346.35217285,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN7 = AddStaticVehicleEx(462,805.15179443,-1356.07116699,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN8 = AddStaticVehicleEx(462,805.13153076,-1358.23181152,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN9 = AddStaticVehicleEx(462,805.32397461,-1360.25964355,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN10 = AddStaticVehicleEx(462,805.20800781,-1362.11047363,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN11 = AddStaticVehicleEx(462,805.34686279,-1350.34497070,13.21709442,61.99584961,2,1,15); //Faggio
    SPAWN12 = AddStaticVehicleEx(510,811.65899658,-1335.24926758,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    SPAWN13 = AddStaticVehicleEx(510,813.48510742,-1335.36901855,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    SPAWN14 = AddStaticVehicleEx(510,815.92034912,-1335.47180176,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    SPAWN15 = AddStaticVehicleEx(510,818.55474854,-1335.50842285,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    SPAWN16 = AddStaticVehicleEx(510,820.99645996,-1335.55310059,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    SPAWN17 = AddStaticVehicleEx(510,823.73712158,-1335.52526855,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    SPAWN18 = AddStaticVehicleEx(510,826.10607910,-1335.70532227,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    SPAWN19 = AddStaticVehicleEx(510,808.85168457,-1335.22448730,13.24271679,0.00000000,-1,-1,15); //Mountain Bike

Here is cmd:

pawn Код:

if(strcmp(cmd, "/rentbike", true) == 0)
    {
        if(IsPlayerConnected(playerid))
        {
            new carid = GetPlayerVehicleID(playerid);
            if(carid >= SPAWN1 && carid <= SPAWN19 )
            {
                new hirefee = HireCost(GetPlayerVehicleID(playerid));
                if(SBizzInfo[0][sbProducts] == 0)
                {
                    GameTextForPlayer(playerid, "~r~No more products", 5000, 1);
                    return 1;
                }
                /*if(PlayerInfo[playerid][pPbiskey] == 0)
                {
                    GameTextForPlayer(playerid, "~w~No charge for the boss", 5000, 3);
                    TogglePlayerControllable(playerid, 1);
                    return 1;
                }*/
                if (GetPlayerMoney(playerid) <  SBizzInfo[0][sbEntranceCost])
                {
                    SendClientMessage(playerid, COLOR_GRAD2, "   You dont have money !");
                    return 1;
                }
                if(HireCar[playerid] != 299)
                {
                    gCarLock[HireCar[playerid]] = 0;
                    UnLockCar(HireCar[playerid]);
                    SendClientMessage(playerid, COLOR_GREY, "You must first back the rented /car/bike  !");
                    return 1;
                }
                foreach (Player, i)
                {
                    if(HireCar[i] == GetPlayerVehicleID(playerid))
                    {
                        SendClientMessage(playerid, COLOR_GREY, "    Someone alredy rent this bike/car !");
                        return 1;
                    }
                }
                SafeGivePlayerMoney(playerid,-SBizzInfo[0][sbEntranceCost]);
                SBizzInfo[0][sbTill] += SBizzInfo[0][sbEntranceCost];
                ExtortionSBiz(0, SBizzInfo[0][sbEntranceCost]);
                SBizzInfo[0][sbProducts]--;
                HireCar[playerid] = GetPlayerVehicleID(playerid);
                OnPropUpdate();
                PlayerPlaySound(playerid, 1052, 0.0, 0.0, 0.0);
                format(string, sizeof(string), "~w~Dont forget to type ~b~/unrentbike~n~~g~/lock ~w~to lock the bike/car",hirefee);
                TogglePlayerControllable(playerid, 1);
                gEngine[GetPlayerVehicleID(playerid)] = 1;
                GameTextForPlayer(playerid, string, 5000, 3);
            }
        }
        return 1;
    }

[Mean]

How can't you rent it, what's the problem, what msg u get?

[GBLTeam]

Quote:

Originally Posted by Mean How can't you rent it, what's the problem, what msg u get?

Im on some bike which is for rent but its not for rent when i enter not showing me the gametext .. or i type /rentbike not working.

Quote:

Originally Posted by ****** Well for one thing you're assuming your IDs are assigned linearly, which may not always be the case. Other than that - what print statements do and don't get executed? It's very difficult to even begin to see what's wrong when you've not explained what should happen, what does happen, what various variables mean and what the english of that text is so most people can actually read it for context...

Translated ..

[GBLTeam]

Quote:

Originally Posted by ****** OK, well place prints throughout your code and see what is and isn't called, and print the values of all the variables every time they change.

So before was with (Car ids):

pawn Код:

if(GetPlayerVehicleID(playerid) >= 153 && GetPlayerVehicleID(playerid) <= 177)

I change to, because no more default ids cars i change everycars because was problems.

pawn Код:

new carid = GetPlayerVehicleID(playerid);
if(carid >= SPAWN1 && carid <= SPAWN19)

or

pawn Код:

if(GetPlayerVehicleID(playerid) >= SPAWN1 && GetPlayerVehicleID(playerid) <= SPAWN19)

Like this working but not showing gametext and saying uknown comand but i lose money and i can /unrentbike

[ronnie3148]

Why don't u just set up the cars as a array.... usually works better

pawn Код:

new rentbike[19];

public IsARentBike(carid)
{
  for(new i = 0; i < sizeof(rentbike); i++)
  {
    if(carid == rentbike[i]) return 1;
    {
      return true;
    }
  }
  return false;
}

rentbike[0] = AddStaticVehicleEx(462,805.32794189,-1344.44934082,13.21709442,62.00000000,2,1,15); //Faggio
    rentbike[1] = AddStaticVehicleEx(462,805.19195557,-1342.43786621,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[2] = AddStaticVehicleEx(462,805.06109619,-1340.42614746,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[3] = AddStaticVehicleEx(462,805.34625244,-1338.56909180,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[4] = AddStaticVehicleEx(462,805.31506348,-1348.18957520,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[5] = AddStaticVehicleEx(462,805.31738281,-1346.35217285,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[6] = AddStaticVehicleEx(462,805.15179443,-1356.07116699,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[7] = AddStaticVehicleEx(462,805.13153076,-1358.23181152,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[8] = AddStaticVehicleEx(462,805.32397461,-1360.25964355,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[9] = AddStaticVehicleEx(462,805.20800781,-1362.11047363,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[10] = AddStaticVehicleEx(462,805.34686279,-1350.34497070,13.21709442,61.99584961,2,1,15); //Faggio
    rentbike[11] = AddStaticVehicleEx(510,811.65899658,-1335.24926758,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    rentbike[12] = AddStaticVehicleEx(510,813.48510742,-1335.36901855,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    rentbike[13] = AddStaticVehicleEx(510,815.92034912,-1335.47180176,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    rentbike[14] = AddStaticVehicleEx(510,818.55474854,-1335.50842285,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    rentbike[15] = AddStaticVehicleEx(510,820.99645996,-1335.55310059,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    rentbike[16] = AddStaticVehicleEx(510,823.73712158,-1335.52526855,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    rentbike[17] = AddStaticVehicleEx(510,826.10607910,-1335.70532227,13.24271679,0.00000000,-1,-1,15); //Mountain Bike
    rentbike[18] = AddStaticVehicleEx(510,808.85168457,-1335.22448730,13.24271679,0.00000000,-1,-1,15); //Mountain Bike

then for your command use...

pawn Код:

if(strcmp(cmd, "/rentbike", true) == 0)
    {
        if(IsPlayerConnected(playerid))
        {
          new carid = GetPlayerVehicleID(playerid);
          if(IsARentBike(carid))
          {
                new hirefee = HireCost(GetPlayerVehicleID(playerid));
                if(SBizzInfo[0][sbProducts] == 0)
                {
                    GameTextForPlayer(playerid, "~r~No more products", 5000, 1);
                    return 1;
                }
                /*if(PlayerInfo[playerid][pPbiskey] == 0)
                {
                    GameTextForPlayer(playerid, "~w~No charge for the boss", 5000, 3);
                    TogglePlayerControllable(playerid, 1);
                    return 1;
                }*/
                if (GetPlayerMoney(playerid) <  SBizzInfo[0][sbEntranceCost])
                {
                    SendClientMessage(playerid, COLOR_GRAD2, "   You dont have money !");
                    return 1;
                }
                if(HireCar[playerid] != 299)
                {
                    gCarLock[HireCar[playerid]] = 0;
                    UnLockCar(HireCar[playerid]);
                    SendClientMessage(playerid, COLOR_GREY, "You must first back the rented /car/bike  !");
                    return 1;
                }
                foreach (Player, i)
                {
                    if(HireCar[i] == GetPlayerVehicleID(playerid))
                    {
                        SendClientMessage(playerid, COLOR_GREY, "    Someone alredy rent this bike/car !");
                        return 1;
                    }
                }
                SafeGivePlayerMoney(playerid,-SBizzInfo[0][sbEntranceCost]);
                SBizzInfo[0][sbTill] += SBizzInfo[0][sbEntranceCost];
                ExtortionSBiz(0, SBizzInfo[0][sbEntranceCost]);
                SBizzInfo[0][sbProducts]--;
                HireCar[playerid] = GetPlayerVehicleID(playerid);
                OnPropUpdate();
                PlayerPlaySound(playerid, 1052, 0.0, 0.0, 0.0);
                format(string, sizeof(string), "~w~Dont forget to type ~b~/unrentbike~n~~g~/lock ~w~to lock the bike/car",hirefee);
                TogglePlayerControllable(playerid, 1);
                gEngine[GetPlayerVehicleID(playerid)] = 1;
                GameTextForPlayer(playerid, string, 5000, 3);
            }
        }
        return 1;
    }