[Fairuz]

how do I optimize this code to reduce lines and makes more understandable?

PHP код:

        if(GetVehicleEngineType(modelid) == 'H')
        {
            format(typestr, 16, "Human Powered");
        }
        else if(GetVehicleEngineType(modelid) == 'D')
        {
            format(typestr, 16, "Diesel");
        }
        else if(GetVehicleEngineType(modelid) == 'P')
        {
            format(typestr, 16, "Petrol");
        }
        else if(GetVehicleEngineType(modelid) == 'E')
        {
            format(typestr, 16, "Electric");
        } 


[Fairuz]

Quote:

Originally Posted by ****** Having said that, you can switch on character constants.

The wiki only provides number so I'm confused how to do it with strings.

[Calisthenics]

For a start, do not call GetVehicleEngineType function 4 times.
if/else if can be replaced with a switch.
format is useless when can set string directly.

pawn Код:

switch (GetVehicleEngineType(modelid))
{
    case 'H': typestr = "Human Powered";
    case 'D': typestr = "Diesel";
    case 'P': typestr = "Petrol";
    case 'E': typestr = "Electric";
}