[bugmenotlol]

PHP Code:

COMMAND:setname(playerid, params[])
{
    new otherID, name[120],query[300];
    if(!adminLevel(playerid, 1))
        return 0;
    if(sscanf(params, "us[100]", otherID, name))
    {
        //Usage(playerid, "pm <playerid> <message>");
        SendClientMessage(playerid, COLOR_RED, "SYNTAX: /setname (playerid) (new name)");
    }
    else
    {
        mysql_format(koneksi, query, sizeof(query), "SELECT * FROM `player` WHERE `name` = '%s' LIMIT 1", name);
        if(cache_num_rows() > 0)
        {
           SendClientMessage(playerid,COLOR_RED,"Player with that name already exists.");
        }
        else
        {
           mysql_format(koneksi, query, sizeof(query), "UPDATE `player` SET `name` = '%s' where `id` = '%d'",name,Player[otherID][pID]);
           mysql_query(koneksi, query, false);
        }
    }
    return 1;
} 


I am not getting any errors but it is not checking whether a player with that name exists or not
and one more thing
is it important to do safestring for this command ? if yes where i have to use it ?

Thnx

++ REP

[HoussemGaming]

You don't run the query
use mysql_tquery

[bugmenotlol]

How to use it ?
plz can u give an example?

[Xeon™]

PHP Code:

COMMAND:setname(playerid, params[]) 
{ 
    new otherID, name[120],query[300]; 
    if(!adminLevel(playerid, 1)) 
        return 0; 
    if(sscanf(params, "us[100]", otherID, name)) 
    { 
        //Usage(playerid, "pm <playerid> <message>"); 
        SendClientMessage(playerid, COLOR_RED, "SYNTAX: /setname (playerid) (new name)"); 
    } 
    else 
    { 
        mysql_format(koneksi, query, sizeof(query), "SELECT * FROM `player` WHERE `name` = '%s' LIMIT 1", name);
        new Cache:getcache = mysql_query(koneksi, query); 
        if(cache_num_rows() > 0) 
        { 
           SendClientMessage(playerid,COLOR_RED,"Player with that name already exists."); 
        } 
        else 
        { 
           mysql_format(koneksi, query, sizeof(query), "UPDATE `player` SET `name` = '%s' where `id` = '%d'",name,Player[otherID][pID]); 
           mysql_query(koneksi, query, false); 
        } 
        cache_delete(getcache);
    } 
    return 1; 
} 


[bugmenotlol]

should i have to use safestring anywhere ??