[YouHack]

Well hello again!
My server crash sometimes when a user do the command /vipname.

PHP код:

CMD:vipname(playerid, params[])
{
    new text[6], szMessage[256];
    new vehicleid = GetPlayerVehicleID(playerid);
    if(sscanf(params, "s[50]", text)) return SCM(playerid, COLOR_WHITE, "SYNTAX: /vipname [name]");
    if(PlayerInfo[playerid][pPremiumAccount] != 1) return SCM(playerid, COLOR_ERROR, "You don't have a premium account");
    {
        if(vText[playerid] != -1) return SCM(playerid, COLOR_WHITE, "Use first /removename to put another name on your car.");
        if(GetPlayerState(playerid) != PLAYER_STATE_DRIVER) return SCM(playerid, COLOR_WHITE, "You aren't in any car.");
        if(GetPlayerState(playerid) == PLAYER_STATE_PASSENGER) return SCM(playerid, COLOR_ERROR, "You aren't the driver.");
        if(GetVehicleModel(GetPlayerVehicleID(playerid)) != 411) return SCM(playerid, COLOR_ERROR, "Car must be an Infernus in order to apply this command.");
        if(OwnedVeh(vehicleid))
        {
            vText[playerid] = CreateObject(19327, -2597.0762, -2638.4270, -5.3536, -87.6999, 90.4001, -87.1805);
            SetObjectMaterialText(vText[playerid] , text, 0, 50, "Arial", 15, 1, 0xFFFFFFFF, 0, 1);
            AttachObjectToVehicle(vText[playerid] , vehicleid, 0.0,-1.9, 0.3, 270.0, 0.0, 0.0);
            format(szMessage, sizeof(szMessage), "{F2CF09}Vipname is: '%s'", text);
            SCM(playerid, COLOR_YELLOW, szMessage);
            new var[64];
            mysql_format(SQL, var, sizeof(var),"UPDATE `users` SET `vipnameinf`='%s' WHERE `name`='%d'", text, PlayerInfo[playerid][pNormalName]);
            mysql_tquery(SQL, var,"","");
        }
    }
    return 1;
} 


Also , i can't make a query to load the vipnameinf OnPlayerLogin . :/
Using MySQL R34.

[AjaxM]

Below posts got it right.

[oMa37]

Increase the text size to 50, You have defined it as 6 and 50 in the sscanf check, I'm not sure if this is the issue but you should fix that.

PHP код:

new text[50];
if(sscanf(params, "s[50]", text)) return ... 


EDIT:

PHP код:

UPDATE `users` SET `vipnameinf`='%s' WHERE `name`='%d' 


the 'name' column is a string? If so change it to `name`='%s'

[Wolfe]

As said above ^

pawn Код:

mysql_format(SQL, var, sizeof(var),"UPDATE `users` SET `vipnameinf`='%s' WHERE `name`='%d'", text, PlayerInfo[playerid][pNormalName]);

You're attempting to save a player name as %d when it needs to be saved as a string. %d treats it as if it was an integer.

Integer = whole number
String = characters

However I'm not sure if that would cause the crash, but it could be.

The fixed version would be;

pawn Код:

mysql_format(SQL, var, sizeof(var),"UPDATE `users` SET `vipnameinf`='%s' WHERE `name`='%s'", text, PlayerInfo[playerid][pNormalName]);

[YouHack]

so %d used for a number , not string? if so, why it is working sometimes?

[darkdrago]

%d is for integers, i don't really know why it sometimes works for you but the string is %s
If you use %d it would give some random numbers

[iLearner]

Quote:

UPDATE `users` SET `vipnameinf`='%s' WHERE `name`='%d'

Integers dont need ' '

[YouHack]

i will try it 6~9 times and see if crash now.