1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
Calling Functions
Yaa
Banned
Posts: 599
Threads: 48
Joined: May 2016
#1

28.12.2016, 20:23
hi,

recently i added a mysql function can accept guests but after OnPlayerConnect server freeze and OnPlayerRequestClass not called :/

idk why

this is last lines on onplayerconnect

PHP код:
    new queryS[128], Cache:resultsX;
    mysql_format(register, queryS, sizeof(queryS), "SELECT `Password` FROM `accounts` WHERE `Name` = '%s' LIMIT 1", GetName(playerid)); 
    resultsX = mysql_query(register, queryS);
    new 
        rows, 
        fields; 
    cache_get_row_count(rows);
    cache_get_field_count(fields); 
    if(rows) 
    { 
        cache_get_value_name(0, "Password", PlayerInfo[playerid][Password]); 
        ShowPlayerDialog(playerid, Login+200, DIALOG_STYLE_INPUT, "Login", "Welcome !\nthis account already registred. Please fill in your password:", "Login", "Quit"); 
    } 
    else
    {
        isGuest[playerid] = 1;
    }
    cache_delete(resultsX);
    return 1;
} 
any ideas ?

Pics:

Find
Reply
BiosMarcel
Banned
Posts: 1,219
Threads: 51
Joined: Jul 2012
#2

28.12.2016, 21:06
Here you go, Mr. Lead Scripter:

PHP код:
    new queryS[128]; 
    mysql_format(register, queryS, sizeof(queryS), "SELECT Password FROM accounts WHERE Name = '%e' LIMIT 1;", GetName(playerid));  
    new Cache:resultsX = mysql_query(register, queryS); 
    new rows;
    cache_get_row_count(rows); 
    
    if(rows)  
    {  
        cache_get_value_name(0, "Password", PlayerInfo[playerid][Password]);  
        cache_delete(resultsX); 
        ShowPlayerDialog(playerid, Login+200, DIALOG_STYLE_INPUT, "Login", "Welcome !\nthis account already registred. Please fill in your password:", "Login", "Quit");  
    }  
    else 
    { 
        isGuest[playerid] = 1; 
    } 
    return 1; 
} 
And yes, your code will still fail i guess, anyways, use mysql_errno() to check if u get any errors and check your mysql log.


Btw you might not want to use Limit 1 in that case, since it should be impossible to get more than 1, if u get more, you have a defect in your register system
Find
Reply
SickAttack
High-roller
*****
Posts: 4,759
Threads: 33
Joined: Dec 2013
Reputation: 0
#3

28.12.2016, 23:33
Quote:
Originally Posted by [Bios]Marcel
Посмотреть сообщение
Here you go, Mr. Lead Scripter:

PHP код:
    new queryS[128]; 
    mysql_format(register, queryS, sizeof(queryS), "SELECT Password FROM accounts WHERE Name = '%e' LIMIT 1;", GetName(playerid));  
    new Cache:resultsX = mysql_query(register, queryS); 
    new rows;
    cache_get_row_count(rows); 
    
    if(rows)  
    {  
        cache_get_value_name(0, "Password", PlayerInfo[playerid][Password]);  
        cache_delete(resultsX); 
        ShowPlayerDialog(playerid, Login+200, DIALOG_STYLE_INPUT, "Login", "Welcome !\nthis account already registred. Please fill in your password:", "Login", "Quit");  
    }  
    else 
    { 
        isGuest[playerid] = 1; 
    } 
    return 1; 
} 
And yes, your code will still fail i guess, anyways, use mysql_errno() to check if u get any errors and check your mysql log.


Btw you might not want to use Limit 1 in that case, since it should be impossible to get more than 1, if u get more, you have a defect in your register system
It's always good to use LIMIT 1, so it will return only 1 result.
Find
Reply
Gammix
High-roller
*****
Posts: 1,773
Threads: 47
Joined: Jan 2015
Reputation: 0
#4

29.12.2016, 09:38
Quote:
Originally Posted by [Bios]Marcel
Посмотреть сообщение
Here you go, Mr. Lead Scripter:

PHP код:
    new queryS[128]; 
    mysql_format(register, queryS, sizeof(queryS), "SELECT Password FROM accounts WHERE Name = '%e' LIMIT 1;", GetName(playerid));  
    new Cache:resultsX = mysql_query(register, queryS); 
    new rows;
    cache_get_row_count(rows); 
    
    if(rows)  
    {  
        cache_get_value_name(0, "Password", PlayerInfo[playerid][Password]);  
        cache_delete(resultsX); 
        ShowPlayerDialog(playerid, Login+200, DIALOG_STYLE_INPUT, "Login", "Welcome !\nthis account already registred. Please fill in your password:", "Login", "Quit");  
    }  
    else 
    { 
        isGuest[playerid] = 1; 
    } 
    return 1; 
} 
And yes, your code will still fail i guess, anyways, use mysql_errno() to check if u get any errors and check your mysql log.


Btw you might not want to use Limit 1 in that case, since it should be impossible to get more than 1, if u get more, you have a defect in your register system
Setting limit will ofcourse increase performance since when system finds one or specified number of match it will "break" searching through rows and prepare cache/result.
Find
Reply
BiosMarcel
Banned
Posts: 1,219
Threads: 51
Joined: Jul 2012
#5

29.12.2016, 09:45
Quote:
Originally Posted by Gammix
Посмотреть сообщение
Setting limit will ofcourse increase performance since when system finds one or specified number of match it will "break" searching through rows and prepare cache/result.
Good point!
Find
Reply
Gammix
High-roller
*****
Posts: 1,773
Threads: 47
Joined: Jan 2015
Reputation: 0
#6

29.12.2016, 09:58
Since its non threaded query, either mysql_query is taking forever to execute which is ultimately freezing player in OnPlayerConnect thread or its not related to the code you gave us.
Find
Reply
Yaa
Banned
Posts: 599
Threads: 48
Joined: May 2016
#7

29.12.2016, 10:28
full code :

PHP код:
public OnPlayerConnect(playerid) 
{ 
    if(BetaVersion == 1)
    {
        TogglePlayerSpectating(playerid, true); 
        new query[128];
        mysql_format(register, query, sizeof(query), "SELECT `Password`, `ID` FROM `accounts` WHERE `Name` = '%s' LIMIT 1", GetName(playerid)); 
        mysql_tquery(register, query, "OnMySQLInit", "i", playerid);
        return 1;
    }
    inEvent[playerid] = false;
    PlayAudioStreamForPlayer(playerid, "https://ia601504.us.archive.org/35/items/login_201612/login.mp3");
    TextDrawShowForPlayer(playerid, Visual[0]);
    TextDrawShowForPlayer(playerid, Visual[1]);
    for(new i = 0; i < 50; i++) SendClientMessage(playerid, COLOR_WHITE,"");
    for(new i = 0; i < 50; i++) SendClientMessage(playerid, COLOR_WHITE,"");
    new stringjk[100];
    format(stringjk,sizeof(stringjk), ""GRI"**%s[%d] Has joined "R"Vice Land", GetName(playerid), playerid);
    SendClientMessageToAll(COLOR_GREY, stringjk);
    SendClientMessage(playerid, COLOR_GOLD,   "[VCL] : Welcome To Vice Land");
    SendClientMessage(playerid, COLOR_ORANGE, "[VCL] : You Can use /cmds for see Commands");
    SendClientMessage(playerid, COLOR_ORANGE, "[VCL] : I Hope you like our Server" );
    SendClientMessage(playerid, COLOR_ORANGE, "[VCL] : Enjoy !");
    SetPlayerColor(playerid, PlayerColors[playerid]);
    InitFly(playerid);
    new joinMsg[80];
    format(joinMsg, sizeof(joinMsg), "02[%d] 03*** %s has joined Vice Land.", playerid, GetName(playerid));
    IRC_GroupSay(groupID, IRCChannel, joinMsg);
    SetTimerEx("OnAntiCheatLoad", 500, 1, "i", playerid);
    SetTimerEx("onLVPiratesShipUpdate", 500, 1, "i", playerid);
    SpawnArmour[playerid] = 0;
    SpawnProtection[playerid] = 0;
    SPDuration[playerid] = 0;
    Ammo[playerid] = 0;
    MyCar[playerid] = 0;
    SetPVarInt(playerid, "dWep0", 0);
    SetPVarInt(playerid, "dWep1", 0);
    SetPVarInt(playerid, "dWep2", 0);
    SetPVarInt(playerid, "dPID", -1);
    SetPVarInt(playerid, "dLoc", -1);
    SetPVarInt(playerid, "dBet", 0);
    SetPlayerMapIcon(playerid, 6, 2085.0610, 1577.1023, 11.4341, 6, 0, MAPICON_LOCAL);
    RemoveBuildingForPlayer(playerid, 3509, 2089.320, 1583.479, 9.726, 0.250);
    RemoveBuildingForPlayer(playerid, 3509, 2089.320, 1566.189, 9.726, 0.250);
    RemoveBuildingForPlayer(playerid, 3509, 2109.050, 1547.270, 9.773, 0.250);
    RemoveBuildingForPlayer(playerid, 8623, 2093.879, 1553.510, 10.570, 0.250);
    RemoveBuildingForPlayer(playerid, 8618, 2093.679, 1553.319, 22.828, 0.250);
    RemoveBuildingForPlayer(playerid, 8971, 2093.679, 1553.319, 22.828, 0.250);
    RemoveBuildingForPlayer(playerid, 1350, 2082.5156, 1538.8125, 9.7891, 0.25);
    AudioDJ[playerid] = 0;
    PropTycoon[playerid] = 0;
    RemoveBuildingForPlayer(playerid, 8969, 2071.6250, 702.8906, 22.0078, 0.25);
    RemoveBuildingForPlayer(playerid, 3459, 2257.3750, 623.4297, 17.2969, 0.25);
    RemoveBuildingForPlayer(playerid, 1350, 2277.2578, 627.6719, 9.8125, 0.25);
    RemoveBuildingForPlayer(playerid, 1350, 2297.5000, 638.7891, 9.7422, 0.25);
    RemoveBuildingForPlayer(playerid, 1350, 2281.8125, 643.3359, 9.7891, 0.25);
    RemoveBuildingForPlayer(playerid, 1294, 2283.2656, 653.8125, 14.3047, 0.25);
    RemoveBuildingForPlayer(playerid, 1294, 2291.5625, 692.0938, 14.3047, 0.25);
    RemoveBuildingForPlayer(playerid, 1350, 2293.0156, 703.1172, 9.7969, 0.25);
    RemoveBuildingForPlayer(playerid, 3459, 2346.6484, 623.4297, 17.2969, 0.25);
    RemoveBuildingForPlayer(playerid, 3459, 2411.7656, 623.4297, 17.2969, 0.25);
    RemoveBuildingForPlayer(playerid, 8596, 2490.4297, 703.1953, 21.9453, 0.25);
    for(new i; i < _:G_USER_DATA; ++i)
        GInfo[playerid][G_USER_DATA:i] = 0;
    Iter_Add(SS_Player, playerid);
    GetPlayerName(playerid, GInfo[playerid][username], MAX_PLAYER_NAME);
    GInfo[playerid][Capturing] = false;
//** some texdraws
    foreach(new i : Zones)
    {
        if(isnull(ZInfo[i][Owner]))
            GangZoneShowForPlayer(playerid, ZInfo[i][_Zone], ZONE_COLOR);
        else
            GangZoneShowForPlayer(playerid, ZInfo[i][_Zone], ZInfo[i][Color]);
    }
    new IPx[16], Adminx[20], reason[50];
    GetPlayerIp(playerid, IPx, sizeof(IPx));
    new querys[128], Cache:results;
    format(querys, 128, "SELECT * FROM `banlist` WHERE `ip` = '%s'", IPx);
       results =  mysql_query(register, querys);
    new rowsK;
    cache_get_row_count(rowsK);
    if(rowsK)
    {
        cache_get_value_name(0, "Admin", Adminx);
        cache_get_value_name(0, "Reason", reason);
        new str[150];
        for(new i = 0; i < 50; i++) SendClientMessage(playerid, COLOR_WHITE,"");
        for(new i = 0; i < 50; i++) SendClientMessage(playerid, COLOR_WHITE,"");
        SendClientMessage(playerid, -1,""YE"You are Still Banned From x");
        format(str, sizeof(str), "You are Banned by Administrator : "R"%s "W"with given a reason : "R"%s", Adminx, reason );
        SendClientMessage(playerid, -1, str);
        SendClientMessage(playerid, -1, "if You Think This Ban was unfair ! Feel Free to create a ban appeal in our forum ");
        SetTimerEx("DelayKick", 1000, false, "i", playerid);
    }
    TogglePlayerSpectating(playerid, true); 
    cache_delete(results);
    new queryS[128], Cache:resultsX;
    mysql_format(register, queryS, sizeof(queryS), "SELECT `Password` FROM `accounts` WHERE `Name` = '%s' LIMIT 1", GetName(playerid)); 
    resultsX = mysql_query(register, queryS);
    new 
        rows, 
        fields; 
    cache_get_row_count(rows);
    cache_get_field_count(fields); 
    if(rows) 
    { 
        cache_get_value_name(0, "Password", PlayerInfo[playerid][Password]); 
        ShowPlayerDialog(playerid, Login+200, DIALOG_STYLE_INPUT, "Login", "Welcome !\nthis account already registred. Please fill in your password:", "Login", "Quit"); 
        return 1;
    } 
    cache_delete(resultsX);
    isGuest[playerid] = 1;
    return 1; 
} 
notice: BetaVersion = 0

about mysql logs (error.log, warnings.log) are empty's
Find
Reply
iLearner
Unregistered
 
#8

29.12.2016, 11:56
Can you show us where you established the connection to db?
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help