[aoky]

When a player kills another player, their scores are not going up. Here's the OnPlayerDeath code.
http://pastebin.com/TcCmfS7j

[ISmokezU]

Hey,Look at the example the wiki provided and try to figure it out. https://sampwiki.blast.hk/wiki/OnPlayerDeath
if you still don't understand feel free to reply back but try first.

[Jelly23]

PHP код:

public OnPlayerDeath(playerid, killerid, reason)
{
     SendDeathMessage(killerid, playerid, reason);
     if(duelinfo[killerid][induel] == 1)
     {
          duelinfo[killerid][induel] = 0;
          new string[128];
          new Float:health = GetPlayerHealth(killerid, health);
          format(string, sizeof(string), ""RED"[DUEL] "WHITE"%s(%d) has defeated %s(%d) in a duel with %.2f health left", duelinfo[killerid][playername], killerid, duelinfo[playerid][playername], playerid, health);
          SendClientMessageToAll(-1, string);
          SetPlayerScore(killerid, GetPlayerScore(killerid) + 2);
          GiveCoins(killerid, 2);
          PlayerInfo[killerid][pDuelWins] +=1;
          PlayerInfo[playerid][pDuelLoses] +=1;
     }
     GiveCoins(killerid, 1);
     PlayerInfo[killerid][pKills] += 1;
     PlayerInfo[playerid][pDeaths] += 1;
     return 1;
} 


Just look into your code ^, it's pretty obvious, you are increasing the killer's score if they are in a duel only. Also, you should check if the killerid isn't invalid before using it in an array.

[Tass007]

Try this

PHP код:

public OnPlayerDeath(playerid, killerid, reason)
{
    if(killerid == INVALID_PLAYER_ID) return 0;
    SendDeathMessage(killerid, playerid, reason); 
    if(duelinfo[killerid][induel] == 1) 
    { 
        duelinfo[killerid][induel] = 0; 
        new string[128]; 
        new Float:health = GetPlayerHealth(killerid, health); 
        format(string, sizeof(string), ""RED"[DUEL] "WHITE"%s(%d) has defeated %s(%d) in a duel with %.2f health left", duelinfo[killerid][playername], killerid, duelinfo[playerid][playername], playerid, health); 
        SendClientMessageToAll(-1, string); 
        SetPlayerScore(killerid, GetPlayerScore(killerid) + 2); 
        GiveCoins(killerid, 2); 
        PlayerInfo[killerid][pDuelWins] +=1; 
        PlayerInfo[playerid][pDuelLoses] +=1;
    }
    else if(duelinfo[killerid][induel] != 1) 
    {
        GiveCoins(killerid, 1);
        SetPlayerScore(killerid, GetPlayerScore(killerid) + 1); 
        PlayerInfo[killerid][pKills] += 1; 
        PlayerInfo[playerid][pDeaths] += 1;
    }
    return 1;
} 


"You MUST check whether 'killerid' is valid (not INVALID_PLAYER_ID) before using it in an array (or really anywhere), as it will cause the OnPlayerDeath script to crash (not the entire script). This is because INVALID_PLAYER_ID is defined as 65535, and if an array only has 'MAX_PLAYERS' elements, e.g. 500, you're trying to access an index that is above 499, which is out of bounds." - Taken from Wiki

[Jelly23]

Quote:

Originally Posted by Tass007 Try this PHP код: public OnPlayerDeath(playerid, killerid, reason) {     if(killerid == INVALID_PLAYER_ID) return 0;     SendDeathMessage(killerid, playerid, reason);      if(duelinfo[killerid][induel] == 1)      {          duelinfo[killerid][induel] = 0;          new string[128];          new Float:health = GetPlayerHealth(killerid, health);          format(string, sizeof(string), ""RED"[DUEL] "WHITE"%s(%d) has defeated %s(%d) in a duel with %.2f health left", duelinfo[killerid][playername], killerid, duelinfo[playerid][playername], playerid, health);          SendClientMessageToAll(-1, string);          SetPlayerScore(killerid, GetPlayerScore(killerid) + 2);          GiveCoins(killerid, 2);          PlayerInfo[killerid][pDuelWins] +=1;          PlayerInfo[playerid][pDuelLoses] +=1;     }     else if(duelinfo[killerid][induel] != 1)      {         GiveCoins(killerid, 1);         SetPlayerScore(killerid, GetPlayerScore(killerid) + 1);          PlayerInfo[killerid][pKills] += 1;          PlayerInfo[playerid][pDeaths] += 1;     }     return 1; }  "You MUST check whether 'killerid' is valid (not INVALID_PLAYER_ID) before using it in an array (or really anywhere), as it will cause the OnPlayerDeath script to crash (not the entire script). This is because INVALID_PLAYER_ID is defined as 65535, and if an array only has 'MAX_PLAYERS' elements, e.g. 500, you're trying to access an index that is above 499, which is out of bounds." - Taken from Wiki

Quote:

"You MUST check whether 'killerid' is valid (not INVALID_PLAYER_ID) before using it in an array (or really anywhere), as it will cause the OnPlayerDeath script to crash

PHP код:

if(killerid == INVALID_PLAYER_ID) return 0; 


That's bad, there won't be any difference, since the rest of the code won't execute at all if the killerid is invalid.

[Tass007]

Quote:

Originally Posted by Jelly23 PHP код: if(killerid == INVALID_PLAYER_ID) return 0;  That's bad, there won't be any difference, since the rest of the code won't execute at all if the killerid is invalid.

PHP код:

public OnPlayerDeath(playerid, killerid, reason) 
{ 
    if(killerid != INVALID_PLAYER_ID)
    {
        SendDeathMessage(killerid, playerid, reason);  
        if(duelinfo[killerid][induel] == 1)  
        {  
            duelinfo[killerid][induel] = 0;  
            new string[128];  
            new Float:health = GetPlayerHealth(killerid, health);  
            format(string, sizeof(string), ""RED"[DUEL] "WHITE"%s(%d) has defeated %s(%d) in a duel with %.2f health left", duelinfo[killerid][playername], killerid, duelinfo[playerid][playername], playerid, health);  
            SendClientMessageToAll(-1, string);  
            SetPlayerScore(killerid, GetPlayerScore(killerid) + 2);  
            GiveCoins(killerid, 2);  
            PlayerInfo[killerid][pDuelWins] +=1;  
            PlayerInfo[playerid][pDuelLoses] +=1; 
        } 
        else if(duelinfo[killerid][induel] != 1)  
        { 
            GiveCoins(killerid, 1); 
            SetPlayerScore(killerid, GetPlayerScore(killerid) + 1);  
            PlayerInfo[killerid][pKills] += 1;  
            PlayerInfo[playerid][pDeaths] += 1; 
        } 
    }
    return 1; 
} 


Is that better?

[Jelly23]

Quote:

Originally Posted by Tass007 PHP код: public OnPlayerDeath(playerid, killerid, reason)  {      if(killerid != INVALID_PLAYER_ID)     {         SendDeathMessage(killerid, playerid, reason);           if(duelinfo[killerid][induel] == 1)           {               duelinfo[killerid][induel] = 0;               new string[128];               new Float:health = GetPlayerHealth(killerid, health);               format(string, sizeof(string), ""RED"[DUEL] "WHITE"%s(%d) has defeated %s(%d) in a duel with %.2f health left", duelinfo[killerid][playername], killerid, duelinfo[playerid][playername], playerid, health);               SendClientMessageToAll(-1, string);               SetPlayerScore(killerid, GetPlayerScore(killerid) + 2);               GiveCoins(killerid, 2);               PlayerInfo[killerid][pDuelWins] +=1;               PlayerInfo[playerid][pDuelLoses] +=1;          }          else if(duelinfo[killerid][induel] != 1)           {              GiveCoins(killerid, 1);              SetPlayerScore(killerid, GetPlayerScore(killerid) + 1);               PlayerInfo[killerid][pKills] += 1;               PlayerInfo[playerid][pDeaths] += 1;          }      }     return 1;  }  Is that better?

Still, the kill list messages & playerid's deaths will only increase if the killerid is valid, pretty much the same.

Anything related to playerid shouldn't be under if(killerid != INVALID_PLAYER_ID) condition.

[Tass007]

Then how do you suggest to do it then?

[Jelly23]

PHP код:

public OnPlayerDeath(playerid, killerid, reason)  
{  
     SendDeathMessage(killerid, playerid, reason);   
     if(killerid != INVALID_PLAYER_ID && duelinfo[killerid][induel] == 1)   
     {   
         duelinfo[killerid][induel] = 0;   
         new string[128],Float:health = GetPlayerHealth(killerid, health);   
         format(string, sizeof(string), ""RED"[DUEL] "WHITE"%s(%d) has defeated %s(%d) in a duel with %.2f health left", duelinfo[killerid][playername], killerid, duelinfo[playerid][playername], playerid, health);   
         SendClientMessageToAll(-1, string);   
         SetPlayerScore(killerid, GetPlayerScore(killerid) + 2);   
         GiveCoins(killerid, 2);   
         PlayerInfo[killerid][pDuelWins] +=1;   
         PlayerInfo[playerid][pDuelLoses] +=1;  
     }  
     else
     {
         if(killerid != INVALID_PLAYER_ID)
         {  
              GiveCoins(killerid, 1);  
              SetPlayerScore(killerid, GetPlayerScore(killerid) + 1);   
              PlayerInfo[killerid][pKills] += 1;   
         }
         PlayerInfo[playerid][pDeaths] += 1;   
     } 
     return 1;  
} 


[aoky]

I've tried both solutions and still isn't working. Thanks so much for the help either way.