/report command problem
#1

When I Try To Use /report [playerid] [reason],When I Report Someone, It Says: Youssef_Ahmad (0) (Thats me) Has Reported Youssef Ahmad (1) (The Bug Is Here, It Says My Name Again) | Reason: Hacking.

Code:
pawn Код:
COMMAND:report(playerid,params[])
{
      new str[128], string[128], target, reporter[MAX_PLAYER_NAME], reported[MAX_PLAYER_NAME];
      GetPlayerName(playerid, reporter, MAX_PLAYER_NAME);
      GetPlayerName(target, reported, MAX_PLAYER_NAME);
      if(sscanf(params, "us[128]", target, str)) return SendClientMessage(playerid, 0xFF0000AA, "USAGE: /report [playerid] [reason]");
      if(target == playerid) return SendClientMessage(playerid, 0xFF0000AA, "You Cannot Report Yourself!");
      if(!IsPlayerConnected(target) || target == INVALID_PLAYER_ID) return SendClientMessage(playerid, 0xFF0000AA, "Player Is Not Connected.");
      SendClientMessage(playerid, 0xFFF700FF, "You Report Has Successfully Sent To Online Admins, Thanks For Reporting!");
      new File:reports = fopen("Reports.ini", io_append);
      if (reports)
      {
         new year,month,day;
         getdate(year, month, day);
         format(string, sizeof string, "%s Has Reported %s | Reason: %s | Date: %d/%d/%d.", reporter, reported, str, day, month, year);
         fwrite(reports, string);
         fclose(reports);
      }
      foreach(Player, i)
      {
      if(PlayerInfo[i][pAdmin] > 0)
      {
      format(string, sizeof(string), "[Report]: %s (%d) Is Reporting %s (%d) -  Reason: %s.", reporter, playerid, reported, target, str);
      SendClientMessage(i, 0xFFA600AA, string);
      }
      }
      return 1;
}
Reply
#2

Try this one
Код:
COMMAND:report(playerid, params[])
{

        new
			pplayerid,string[1000],reason[100];
        if(sscanf(params, "ds[100]", pplayerid,reason)) return SCM(playerid, COLOR_RED, ""COL_CYAN"Info: "COL_WHITE"/Report (Playerid) (Reason)");
        if(pplayerid == IPI) return SCM(playerid, -1, ""COL_RED"Error: "COL_WHITE"Wrong Playerid.");
        format(string,sizeof(string),""COL_BLUE"(REPORT): "COL_WHITE" \"%s (%d)\" has reported against \"%s (%d)\". (Reason: %s)",GetName(playerid),playerid,GetName(pplayerid),pplayerid,reason);
        SendAdminMessage(string);
        SCM(playerid, -1, ""COL_GREEN"Report successfully sended, please wait for the admins to take action.");
        return 1;
}
Reply
#3

kidding me, right? it's not working.
Reply
#4

Quote:
Originally Posted by Youssef214
Посмотреть сообщение
When I Try To Use /report [playerid] [reason],When I Report Someone, It Says: Youssef_Ahmad (0) (Thats me) Has Reported Youssef Ahmad (1) (The Bug Is Here, It Says My Name Again) | Reason: Hacking.

Code:
pawn Код:
COMMAND:report(playerid,params[])
{
      new str[128], string[128], target, reporter[MAX_PLAYER_NAME], reported[MAX_PLAYER_NAME];
      GetPlayerName(playerid, reporter, MAX_PLAYER_NAME);
      GetPlayerName(target, reported, MAX_PLAYER_NAME);
      if(sscanf(params, "us[128]", target, str)) return SendClientMessage(playerid, 0xFF0000AA, "USAGE: /report [playerid] [reason]");
      if(target == playerid) return SendClientMessage(playerid, 0xFF0000AA, "You Cannot Report Yourself!");
      if(!IsPlayerConnected(target) || target == INVALID_PLAYER_ID) return SendClientMessage(playerid, 0xFF0000AA, "Player Is Not Connected.");
      SendClientMessage(playerid, 0xFFF700FF, "You Report Has Successfully Sent To Online Admins, Thanks For Reporting!");
      new File:reports = fopen("Reports.ini", io_append);
      if (reports)
      {
         new year,month,day;
         getdate(year, month, day);
         format(string, sizeof string, "%s Has Reported %s | Reason: %s | Date: %d/%d/%d.", reporter, reported, str, day, month, year);
         fwrite(reports, string);
         fclose(reports);
      }
      foreach(Player, i)
      {
      if(PlayerInfo[i][pAdmin] > 0)
      {
      format(string, sizeof(string), "[Report]: %s (%d) Is Reporting %s (%d) -  Reason: %s.", reporter, playerid, reported, target, str);
      SendClientMessage(i, 0xFFA600AA, string);
      }
      }
      return 1;
}
Let me explain you why.
You put
pawn Код:
GetPlayerName(target, reported, MAX_PLAYER_NAME);
Before sscanf, which means, target is still assigned to the default value, 0 (afaik).
So, the fix, is actually simple, just put GetPlayerName of target after sscanf, and IsPlayerConnected checks.
pawn Код:
COMMAND:report(playerid,params[])
{
      new str[128], string[128], target, reporter[MAX_PLAYER_NAME], reported[MAX_PLAYER_NAME];
      GetPlayerName(playerid, reporter, MAX_PLAYER_NAME);
      if(sscanf(params, "us[128]", target, str)) return SendClientMessage(playerid, 0xFF0000AA, "USAGE: /report [playerid] [reason]");
      if(target == playerid) return SendClientMessage(playerid, 0xFF0000AA, "You Cannot Report Yourself!");
      if(!IsPlayerConnected(target) || target == INVALID_PLAYER_ID) return SendClientMessage(playerid, 0xFF0000AA, "Player Is Not Connected.");
      GetPlayerName(target, reported, MAX_PLAYER_NAME);
      SendClientMessage(playerid, 0xFFF700FF, "You Report Has Successfully Sent To Online Admins, Thanks For Reporting!");
      new File:reports = fopen("Reports.ini", io_append);
      if (reports)
      {
         new year,month,day;
         getdate(year, month, day);
         format(string, sizeof string, "%s Has Reported %s | Reason: %s | Date: %d/%d/%d.", reporter, reported, str, day, month, year);
         fwrite(reports, string);
         fclose(reports);
      }
      foreach(Player, i)
      {
      if(PlayerInfo[i][pAdmin] > 0)
      {
      format(string, sizeof(string), "[Report]: %s (%d) Is Reporting %s (%d) -  Reason: %s.", reporter, playerid, reported, target, str);
      SendClientMessage(i, 0xFFA600AA, string);
      }
      }
      return 1;
}
Hope I helped.
Reply
#5

You try to get the name of targetid before the sscanf check, so try this:

pawn Код:
COMMAND:report(playerid,params[])
{
      new str[128], string[128], target, reporter[MAX_PLAYER_NAME], reported[MAX_PLAYER_NAME];
      GetPlayerName(playerid, reporter, MAX_PLAYER_NAME);
      if(sscanf(params, "us[128]", target, str)) return SendClientMessage(playerid, 0xFF0000AA, "USAGE: /report [playerid] [reason]");
      if(target == playerid) return SendClientMessage(playerid, 0xFF0000AA, "You Cannot Report Yourself!");
      if(!IsPlayerConnected(target) || target == INVALID_PLAYER_ID) return SendClientMessage(playerid, 0xFF0000AA, "Player Is Not Connected.");
      SendClientMessage(playerid, 0xFFF700FF, "You Report Has Successfully Sent To Online Admins, Thanks For Reporting!");
      GetPlayerName(target, reported, MAX_PLAYER_NAME);
      new File:reports = fopen("Reports.ini", io_append);
      if (reports)
      {
         new year,month,day;
         getdate(year, month, day);
         format(string, sizeof string, "%s Has Reported %s | Reason: %s | Date: %d/%d/%d.", reporter, reported, str, day, month, year);
         fwrite(reports, string);
         fclose(reports);
      }
      foreach(Player, i)
      {
      if(PlayerInfo[i][pAdmin] > 0)
      {
      format(string, sizeof(string), "[Report]: %s (%d) Is Reporting %s (%d) -  Reason: %s.", reporter, playerid, reported, target, str);
      SendClientMessage(i, 0xFFA600AA, string);
      }
      }
      return 1;
}
EDIT: Oh shit, didn't see the post above me, sorry
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)