/pullover problems
#1

Hello, i am scripting a CopsnRobbers gm. I got some problems with my /pullover command. When i am outside of a vehicle, and do /pullover. It says Unknown Command. But when i am inside of a vehicle. It says /pullover ID. As i requsted it.

this is my /pullover cmd

pawn Код:
if(strcmp(cmd, "/pullover", true) == 0)
    {
        if(IsPlayerInAnyVehicle(playerid))
        {
            if(IsPlayerInAnyVehicle(giveplayerid))
            {
                if(gTeam[playerid] == TEAM_POLICE)
                {
                    tmp = strtok(cmdtext, idx);
                    if(!strlen(tmp)) {
                    SendClientMessage(playerid, COLOR_GREEN, "/pullover ID - Ask the player to pull over");
                    return 1;
                }
                    giveplayerid = ReturnUser(tmp);
                    if(IsPlayerConnected(giveplayerid))
                {
                if(giveplayerid != INVALID_PLAYER_ID)
                {
                    GetPlayerName(playerid, sendername, sizeof(sendername));
                    format(string, sizeof(string), "%s has asked you to pullover",sendername);
                    GameTextForPlayer(giveplayerid, string, 3500, 5);
                    //GameTextForPlayer(playerid, "~g~ Pullover request sent", 3500, 3);
                    return 1;
                }
                else
                {
                    SendClientMessage(playerid, COLOR_RED, "The player is not in a vehicle");
                }
            }
                    else
            {
                SendClientMessage(playerid, COLOR_RED, "You are not in a vehicle");
                return 1;
                }
            }
        }
    }
}
anyone know how to solve this??

Thanks, Alex
Reply
#2

pawn Код:
if(strcmp(cmd, "/pullover", true) == 0)
    {
        if(IsPlayerInAnyVehicle(playerid))
        {
            if(IsPlayerInAnyVehicle(giveplayerid))
            {
                if(gTeam[playerid] == TEAM_POLICE)
                {
                    tmp = strtok(cmdtext, idx);
                    if(!strlen(tmp)) {
                    SendClientMessage(playerid, COLOR_GREEN, "/pullover ID - Ask the player to pull over");
                }
                    giveplayerid = ReturnUser(tmp);
                    if(IsPlayerConnected(giveplayerid))
                {
                if(giveplayerid != INVALID_PLAYER_ID)
                {
                    GetPlayerName(playerid, sendername, sizeof(sendername));
                    format(string, sizeof(string), "%s has asked you to pullover",sendername);
                    GameTextForPlayer(giveplayerid, string, 3500, 5);
                    //GameTextForPlayer(playerid, "~g~ Pullover request sent", 3500, 3);
                }
                else
                {
                    SendClientMessage(playerid, COLOR_RED, "The player is not in a vehicle");
                }
            }
                    else
            {
                SendClientMessage(playerid, COLOR_RED, "You are not in a vehicle");
                }
            }
        }
    }
    return 1;
}
Sorry about the indentations.. blame the forum. Paste it in and fix them. The problem was that you had
pawn Код:
return 1;
everywhere. You only need 1 -- at the bottom of the command between the last 2 closing brackets.
Reply
#3

Oh okey, thanks :P

EDIT: now it dosent send Unknown command, when you are outside of a vehicle. It dosent say anything. But when i am in a vehicle, it says /pullover ID and You are not in a vehicle
Reply
#4

bump
Reply
#5

This is my current code:
pawn Код:
if(strcmp(cmd, "/pullover", true) == 0)
    {
        if(IsPlayerInAnyVehicle(playerid))
        {
            if(IsPlayerInAnyVehicle(giveplayerid))
            {
                if(gTeam[playerid] == TEAM_POLICE)
                {
                    tmp = strtok(cmdtext, idx);
                    if(!strlen(tmp)) {
                    SendClientMessage(playerid, COLOR_GREEN, "/pullover ID - Ask the player to pull over");
                }
                    giveplayerid = ReturnUser(tmp);
                    if(IsPlayerConnected(giveplayerid))
                {
                if(giveplayerid != INVALID_PLAYER_ID)
                {
                    GetPlayerName(playerid, sendername, sizeof(sendername));
                    format(string, sizeof(string), "%s has asked you to pullover",sendername);
                    GameTextForPlayer(giveplayerid, string, 3500, 5);
                    //GameTextForPlayer(playerid, "~g~ Pullover request sent", 3500, 3);
                }
                else
                {
                    SendClientMessage(playerid, COLOR_RED, "The player is not in a vehicle");
                }
            }
                    else
            {
                SendClientMessage(playerid, COLOR_RED, "You are not in a vehicle");
                }
            }
        }
    }
    return 1;
}
it dosent send Unknown command, when you are outside of a vehicle. It dosent say anything. But when i am in a vehicle, it says /pullover ID and You are not in a vehicle
Reply
#6

pawn Код:
if(strcmp(cmd, "/pullover", true) == 0)
    {
        if(IsPlayerInAnyVehicle(playerid))
        {
            if(IsPlayerInAnyVehicle(giveplayerid))
            {
                if(gTeam[playerid] == TEAM_POLICE)
                {
                    tmp = strtok(cmdtext, idx);
                    if(!strlen(tmp)) {
                    SendClientMessage(playerid, COLOR_GREEN, "/pullover ID - Ask the player to pull over");
                }
                    giveplayerid = ReturnUser(tmp);
                    if(IsPlayerConnected(giveplayerid))
                {
                if(giveplayerid != INVALID_PLAYER_ID)
                {
                    GetPlayerName(playerid, sendername, sizeof(sendername));
                    format(string, sizeof(string), "%s has asked you to pullover",sendername);
                    GameTextForPlayer(giveplayerid, string, 3500, 5);
                    //GameTextForPlayer(playerid, "~g~ Pullover request sent", 3500, 3);
                }
            }else {
                SendClientMessage(playerid, COLOR_RED, "The player is not in a vehicle");
            }
        }else {
            SendClientMessage(playerid, COLOR_RED, "You are not in a vehicle!");
        }
    }
    return 1;
}
Try this. Note: I didn't test it.
Reply
#7

pawn Код:
if(strcmp(cmd, "/pullover", true) == 0)
    {
        giveplayerid = ReturnUser(tmp);
        tmp = strtok(cmdtext, idx);
        if(IsPlayerInAnyVehicle(playerid))return SendClientMessage(playerid,COLOR_RED,"You arent in any vehicle!");
        if(IsPlayerInAnyVehicle(giveplayerid)) return SendClientMessage(playerid,COLOR_RED,"Player isn't in any vehicle!");
        if(gTeam[playerid] != TEAM_POLICE) return SendClientMessage(playerid,COLOR_RED,"You arent cop!");
        if(giveplayerid != INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"Unknown ID");
        if(!strlen(tmp)) return SendClientMessage(playerid, COLOR_GREEN, "/pullover ID - Ask the player to pull over");
        GetPlayerName(playerid, sendername, sizeof(sendername));
        format(string, sizeof(string), "%s has asked you to pullover",sendername);
        GameTextForPlayer(giveplayerid, string, 3500, 5);
        return 1;
        //GameTextForPlayer(playerid, "~g~ Pullover request sent", 3500, 3);
    }
Try it
Reply
#8

Quote:
Originally Posted by admantis
Посмотреть сообщение
pawn Код:
if(strcmp(cmd, "/pullover", true) == 0)
    {
        giveplayerid = ReturnUser(tmp);
        tmp = strtok(cmdtext, idx);
        if(IsPlayerInAnyVehicle(playerid))return SendClientMessage(playerid,COLOR_RED,"You arent in any vehicle!");
        if(IsPlayerInAnyVehicle(giveplayerid)) return SendClientMessage(playerid,COLOR_RED,"Player isn't in any vehicle!");
        if(gTeam[playerid] != TEAM_POLICE) return SendClientMessage(playerid,COLOR_RED,"You arent cop!");
        if(giveplayerid != INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"Unknown ID");
        if(!strlen(tmp)) return SendClientMessage(playerid, COLOR_GREEN, "/pullover ID - Ask the player to pull over");
        GetPlayerName(playerid, sendername, sizeof(sendername));
        format(string, sizeof(string), "%s has asked you to pullover",sendername);
        GameTextForPlayer(giveplayerid, string, 3500, 5);
        return 1;
        //GameTextForPlayer(playerid, "~g~ Pullover request sent", 3500, 3);
    }
Try it
The /pullover ID text shows up when i am outside of a vehicle. But when i get inside of a vehicle, it says: You are not in a vehicle. And nothing else happends
Reply
#9

pawn Код:
if(strcmp(cmd, "/pullover", true) == 0)
    {
        if(gTeam[playerid] != TEAM_POLICE) return SendClientMessage(playerid,COLOR_RED,"You arent cop!");
        if(!IsPlayerInAnyVehicle(playerid)) return SendClientMessage(playerid,COLOR_RED,"You arent in any vehicle!");
        tmp = strtok(cmdtext, idx);
        if(!strlen(tmp)) return SendClientMessage(playerid, COLOR_GREEN, "/pullover ID - Ask the player to pull over");
        giveplayerid = ReturnUser(tmp);
        if(!IsPlayerConnected(giveplayerid)) return SendClientMessage(playerid,COLOR_RED,"Unknown ID");
        if(!IsPlayerInAnyVehicle(giveplayerid)) return SendClientMessage(playerid,COLOR_RED,"Player isn't in any vehicle!");
        GetPlayerName(playerid, sendername, sizeof(sendername));
        format(string, sizeof(string), "%s has asked you to pullover",sendername);
        GameTextForPlayer(giveplayerid, string, 3500, 5);
        return 1;
        //GameTextForPlayer(playerid, "~g~ Pullover request sent", 3500, 3);
    }
Reply
#10

pawn Код:
if(strcmp(cmd, "/pullover", true) == 0)
    {
        tmp = strtok(cmdtext, idx);
        if(!strlen(tmp)) return SendClientMessage(playerid, COLOR_GREEN, "/pullover ID - Ask the player to pull over");
        giveplayerid = ReturnUser(tmp);
        if(!IsPlayerInAnyVehicle(playerid))return SendClientMessage(playerid,COLOR_RED,"You arent in any vehicle!");
        if(!IsPlayerInAnyVehicle(giveplayerid)) return SendClientMessage(playerid,COLOR_RED,"Player isn't in any vehicle!");
        if(gTeam[playerid] != TEAM_POLICE) return SendClientMessage(playerid,COLOR_RED,"You arent cop!");
        if(!IsPlayerConnected(giveplayerid)) return SendClientMessage(playerid,COLOR_RED,"Unknown ID");
        GetPlayerName(playerid, sendername, sizeof(sendername));
        format(string, sizeof(string), "%s has asked you to pullover",sendername);
        GameTextForPlayer(giveplayerid, string, 3500, 5);
        return 1;
        //GameTextForPlayer(playerid, "~g~ Pullover request sent", 3500, 3);
    }
Try this.
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)