[introzen]

Hey everyone... I've made 2 commands here witch works almost perfectly fine...

When I do /rankup and i'm in PD. the player gets his new skin...
But when I do /rankdown and i'm in PD. The player doesn't get his new skin =/

Here is the code:

http://pastebin.com/f483b2c30

Thank you =)

[Ro[X]y]

Make a new public for example

Код:

forward SetPlayerRankSkin(playerid);

public SetPlayerRankSkin(playerid)
{
      if(PlayerInfo[playerid][pRank] == 1) { SetPlayerColor(playerid,0x0000FFAA); SetPlayerSkin(playerid,280); }
      else if(PlayerInfo[playerid][pRank] == 2) { SetPlayerColor(playerid,0x0000FFAA); SetPlayerSkin(playerid,280); }
      else if(PlayerInfo[playerid]pRank] == 3) { SetPlayerColor(playerid,0x0000FFAA); SetPlayerSkin(playerid,281); }
      else if(PlayerInfo[playerid][pRank] == 4) { SetPlayerColor(playerid,0x0000FFAA); SetPlayerSkin(playerid,281); }
      else if(PlayerInfo[playerid][pRank] == 5) { SetPlayerColor(playerid,0x0000FFAA); SetPlayerSkin(playerid,282); }
      else if(PlayerInfo[playerid][pRank] == 6) { SetPlayerColor(playerid,0x0000FFAA); SetPlayerSkin(playerid,282); }
      else if(PlayerInfo[playerid][pRank] == 7) { SetPlayerColor(playerid,0x00008BAA); SetPlayerSkin(playerid,288); }
}

and at the command change this:

Код:

		if(PlayerInfo[id][pRank] == 1) SetPlayerSkin(id,280);
	  else if(PlayerInfo[id][pRank] == 2) SetPlayerSkin(id,280);
	  else if(PlayerInfo[id][pRank] == 3) SetPlayerSkin(id,281);
	  else if(PlayerInfo[id][pRank] == 4) SetPlayerSkin(id,281);
	  else if(PlayerInfo[id][pRank] == 5) SetPlayerSkin(id,282);
	  else if(PlayerInfo[id][pRank] == 6) SetPlayerSkin(id,282);
	  else if(PlayerInfo[id][pRank] == 7) SetPlayerSkin(id,288);
	  else if(PlayerInfo[id][pRank] > 7) SetPlayerSkin(id,283);
	  if(PlayerInfo[id][pRank] < 7) SetPlayerColor(id,0x0000FFAA);
	  if(PlayerInfo[id][pRank] > 6) SetPlayerColor(id,0x00008BAA);

to:

Код:

SetPlayerRankSkin(playerid);

[introzen]

Thanks for the advise man :P Makes my whole script much eaiser

But the problem was that I'd put a Return 1; before I made the setskin commands...

Problem Solved =) Thanks :P