[SymonClash]

I have a problem, i have a crate system where players near a spawned crate can get weapons or hp/armour.

Problem is, it should destroy the crate object after the player presses ESC on the dialog (to close it) or when a selects a weapon to get, but it doesn't happen.

Only textlabel gets removed, but crate object stays still there:

pawn Code:

case DIALOG_CRATE:
        {
        if(response)
        {
            if(listitem == 0) // Combat Shotgun.
            {
            GivePlayerWeapon(playerid, 27, 32);
                SendClientMessage(playerid, COLOR_WHITE,"* You have equiped a {FFA500}Combat Shotgun{FFFFFF}.");
                if(IsValidDynamicObject(CrateObject)) DestroyDynamicObject(CrateObject);
                DestroyDynamic3DTextLabel(Text3D:dynamiccrate3DText);
                CrateObject = 0;
            }
            if(listitem == 1) // MP5.
            {
                GivePlayerWeapon(playerid, 29, 32);
                SendClientMessage(playerid, COLOR_WHITE,"* You have equiped a {FFA500}MP5{FFFFFF}.");
                if(IsValidDynamicObject(CrateObject)) DestroyDynamicObject(CrateObject);
                DestroyDynamic3DTextLabel(Text3D:dynamiccrate3DText);
                CrateObject = 0;
            }
        }
        if(!response)
        {
            if(IsValidDynamicObject(CrateObject)) DestroyDynamicObject(CrateObject);
            DestroyDynamic3DTextLabel(Text3D:dynamiccrate3DText);
            CrateObject = 0;
            SendClientMessageTA(-1, "{FFA500}» [CRATE] The crate has been destroyed! Another will respawn soon.");
        }
        }

[Kane]

How many objects do you create?

[SymonClash]

Related to crate? Just 1.

[Kaliber]

Can you show, how you create the object?

[codExpert]

why you repate same useless code so many times, build framwork for this system, at the moment this is useless garbage where you waste time adding something new.

[SymonClash]

Quote:

Originally Posted by codExpert why you repate same useless code so many times, build framwork for this system, at the moment this is useless garbage where you waste time adding something new.

Repeat useless code many times? Where?

@Kaliber:

pawn Code:

new CrateObject;

pawn Code:

new Float:g_CrateSpawns[][3] =
{
    {821.9344,-1868.2295,6.7148}
    {1281.3082,-2000.0718,58.2978},
    {1800.3622,-2180.2473,13.5547},
    {1647.9771,-2102.3044,13.5547}
};

In a timer (crate randomly spawns every 5 mins):

pawn Code:

CrateObject = CreateDynamicObject(CRATE_MODEL_ID, g_CrateSpawns[rand][0], g_CrateSpawns[rand][1], g_CrateSpawns[rand][2]-0.4, -1, -1, -1);

[Kaliber]

Quote:

Originally Posted by SymonClash Repeat useless code many times? Where?

He wanted to say, you could write it like this:

PHP Code:

case DIALOG_CRATE:
{
    if(IsValidDynamicObject(CrateObject)) DestroyDynamicObject(CrateObject);
    DestroyDynamic3DTextLabel(Text3D:dynamiccrate3DText);
    CrateObject = 0;
    if(!response) return SendClientMessageTA(-1, "{FFA500}» [CRATE] The crate has been destroyed! Another will respawn soon.");
    switch(listitem)
    {
        case 0: GivePlayerWeapon(playerid, 27, 32), SendClientMessage(playerid, COLOR_WHITE,"* You have equiped a {FFA500}Combat Shotgun{FFFFFF}.");
        case 1: GivePlayerWeapon(playerid, 29, 32), SendClientMessage(playerid, COLOR_WHITE,"* You have equiped a {FFA500}MP5{FFFFFF}.");
    }
} 


Anyway, i think your problem is, that you overwrite your CrateObject.

Because if you Create the new object the old isnt destroyed and gets overrided.

So, you can solve this, by an array of CrateObjects or by destroying the old one, before you create a new one


PS:
For constant arrays, use stock const:

PHP Code:

stock const Float:g_CrateSpawns[][3] =
{
    {821.9344,-1868.2295,6.7148}
    {1281.3082,-2000.0718,58.2978},
    {1800.3622,-2180.2473,13.5547},
    {1647.9771,-2102.3044,13.5547}
}; 


[SymonClash]

I fixed, i added a bool to check if the object spawned, and now gets removed. Thank you.

[Kasichok]

Quote:

Originally Posted by Kaliber He wanted to say, you could write it like this: PS: For constant arrays, use stock const: PHP Code: stock const Float:g_CrateSpawns[][3] = {     {821.9344,-1868.2295,6.7148}     {1281.3082,-2000.0718,58.2978},     {1800.3622,-2180.2473,13.5547},     {1647.9771,-2102.3044,13.5547} };

what?

Stock only tells the compiler to ignore if not used, there's no reason to use stock for that

[Kaliber]

Quote:

Originally Posted by Kasichok what? Stock only tells the compiler to ignore if not used, there's no reason to use stock for that

No, not in that specific case.

Actually you are right, but you can't declare arrays normally as const (globally).

static const, would be possible or new const, but not const alone.

You can try it out, you will get an error

So to fool the compiler, you can use stock const, then it will work