[Voxel]

Hello, I'm trying to save the players position, health and armour on disconnect but even the skin is not saving. What is wrong here? I can't seem to get it to work.

pawn Код:

enum USER_DATA
{
    USER_ID,
    USER_NAME[MAX_PLAYER_NAME],
    USER_PASSWORD[129],
    USER_IP,
    
    USER_TEAM,
    
    USER_NEW,
    USER_ADMIN,
    USER_HELPER,
    USER_VIP,
    
    USER_AGE,
    USER_SEX,
    USER_ORIGIN,
    
    USER_SCORE,
    
    USER_FACTION,
    USER_LEADER,
    
    USER_HUNGER,
    USER_THIRST,
    USER_ENERGY,
    USER_SLEEP,
    
    Float:USER_LASTX,
    Float:USER_LASTY,
    Float:USER_LASTZ,
    USER_INTERIOR,

    USER_HEALTH,
    USER_ARMOR,
    USER_SKIN,
    USER_FIGHTSTYLE,

    bool: USER_LOGGED_IN
};

pawn Код:

//on player disconnect
if(User[playerid][USER_LOGGED_IN] == true)
    {
        new Float:health, Float:armour;
        User[playerid][USER_HEALTH] = GetPlayerHealth(playerid, health);
        User[playerid][USER_ARMOR] = GetPlayerArmour(playerid, armour);

        GetPlayerPos(playerid, User[playerid][USER_LASTX], User[playerid][USER_LASTY], User[playerid][USER_LASTZ]);
        User[playerid][USER_INTERIOR] = GetPlayerInterior(playerid);

        User[playerid][USER_SCORE] = GetPlayerScore(playerid);
        User[playerid][USER_FIGHTSTYLE] = GetPlayerFightingStyle(playerid);
        User[playerid][USER_SKIN] = GetPlayerSkin(playerid);
    
        new Query[2000];
        format(Query, sizeof(Query), "UPDATE users SET ip = %d, team = %d, new = %d, admin = %d, helper = %d, vip = %d, age = %d, sex = %d, origin = %s, score = %d, faction = %d, leader = %d, hunger = %d, thirst = %d, energy = %d, sleep = %d, lastx = %f, lasty = %f, lastz = %f, interior = %d, health = %d, armor = %d, skin = %d, fightstyle = %d WHERE username = '%s'", User[playerid][USER_IP], User[playerid][USER_TEAM], User[playerid][USER_NEW], User[playerid][USER_ADMIN], User[playerid][USER_HELPER], User[playerid][USER_VIP], User[playerid][USER_AGE], User[playerid][USER_SEX], User[playerid][USER_ORIGIN], User[playerid][USER_SCORE], User[playerid][USER_FACTION], User[playerid][USER_LEADER], User[playerid][USER_HUNGER], User[playerid][USER_THIRST], User[playerid][USER_ENERGY], User[playerid][USER_SLEEP], User[playerid][USER_LASTX], User[playerid][USER_LASTY], User[playerid][USER_LASTZ], User[playerid][USER_INTERIOR], User[playerid][USER_HEALTH], User[playerid][USER_ARMOR], User[playerid][USER_SKIN], User[playerid][USER_FIGHTSTYLE], DB_Escape(User[playerid][USER_NAME]));
        db_query(Database, Query);
        
        SaveInventory(playerid);
    }
    for(new i; i < _: USER_DATA; ++i) User[playerid][USER_DATA: i] = 0;
return 1;
}

pawn Код:

public OnPlayerSpawn(playerid)
{

        
        if(User[playerid][USER_NEW] == 0)
        {
            SendClientMessage(playerid, -1, "[DE-BUG] You are not a new player");
            
            if(User[playerid][USER_HEALTH] == 0)
            {
                SendClientMessage(playerid, -1, "[DE-BUG] You have 0 HP");
            }
            else
            {
                SetPlayerHealth(playerid, User[playerid][USER_HEALTH]);
                SendClientMessage(playerid, -1, "[DE-BUG] You have health");
            }
            
            if(User[playerid][USER_ARMOR] == 0)
            {
                SendClientMessage(playerid, -1, "[DE-BUG] You have 0 armor");
            }
            else
            {
                SetPlayerArmour(playerid, User[playerid][USER_ARMOR]);
                SendClientMessage(playerid, -1, "[DE-BUG] You have armor");
            }

            SetPlayerScore(playerid, User[playerid][USER_SCORE]);
            SetPlayerFightingStyle(playerid, User[playerid][USER_FIGHTSTYLE]);
            SetPlayerSkin(playerid, User[playerid][USER_SKIN]);
            
            SetPlayerPos(playerid, User[playerid][USER_LASTX], User[playerid][USER_LASTY], User[playerid][USER_LASTZ]);
            SetPlayerInterior(playerid, User[playerid][USER_INTERIOR]);
            //SetPlayerPos(playerid, 684.789611, -442.097717, 17.060895);

        }
    return 1;
}

pawn Код:

stock GameMode()
{
    Database = db_open("server.db");
    db_query(Database, "CREATE TABLE IF NOT EXISTS users (userid INTEGER PRIMARY KEY AUTOINCREMENT, username VARCHAR(24) COLLATE NOCASE, password VARCHAR(129), ip INTEGER DEFAULT 0 NOT NULL, team INTEGER DEFAULT 0 NOT NULL, new INTEGER DEFAULT 0 NOT NULL, admin INTEGER DEFAULT 0 NOT NULL, helper INTEGER DEFAULT 0 NOT NULL, vip INTEGER DEFAULT 0 NOT NULL, age INTEGER DEFAULT 0 NOT NULL, sex INTEGER DEFAULT 0 NOT NULL, origin INTEGER DEFAULT 0 NOT NULL, score INTEGER DEFAULT 0 NOT NULL, faction INTEGER DEFAULT 0 NOT NULL, leader INTEGER DEFAULT 0 NOT NULL, hunger INTEGER DEFAULT 0 NOT NULL, thirst INTEGER DEFAULT 0 NOT NULL, energy INTEGER DEFAULT 0 NOT NULL, sleep INTEGER DEFAULT 0 NOT NULL, lastx INTEGER DEFAULT 0 NOT NULL, lasty INTEGER DEFAULT 0 NOT NULL, lastz INTEGER DEFAULT 0 NOT NULL, interior INTEGER DEFAULT 0 NOT NULL, health INTEGER DEFAULT 0 NOT NULL, armor INTEGER DEFAULT 0 NOT NULL, skin INTEGER DEFAULT 0 NOT NULL, fightstyle INTEGER DEFAULT 0 NOT NULL)");
    return 1;
}

[AjaxM]

You should set a timer (probably each seconds) and continuously update the enum for the health, skin, armour and positions.

For example:

PHP код:

forward SavePlayerStats();
public OnGameModeInit()
{
    SetTimer("SavePlayerStats", 1000, true);
    return 1;
}
public SavePlayerStats()
{
    new Float:hp, Float:ar;
    foreach(new i : Player) // foreach 
    {
        GetPlayerHealth(i, hp);
        GetPlayerArmour(i, ar);
        User[i][USER_HEALTH] = hp;
        User[i][USER_ARMOR] = ar;
        User[i][USER_SKIN] = GetPlayerSkin(i);
        // CONTINUE FOR MORE STATS
    }
    return 1;
} 


EDIT ;

You cannot use Get functions under OnPlayerDisconnect.

[MEW273]

What isn't working, are you checking the database and the values aren't saving? Have you checked your mysql error log?

I notice in your code to create the table you are creating the position columns as integers, these should be saved in your database as floats also.

Код:

lastx INTEGER DEFAULT 0 NOT NULL, lasty INTEGER DEFAULT 0 NOT NULL, lastz INTEGER DEFAULT 0 NOT NULL

[Logic_]

It should be REAL not INTEGER for float values ^^

[PT]

And make a Debug in this variable to check if is working propely User[playerid][USER_LOGGED_IN]

[ISmokezU]

Quote:

Originally Posted by AjaxM You should set a timer (probably each seconds) and continuously update the enum for the health, skin, armour and positions. For example: PHP код: forward SavePlayerStats(); public OnGameModeInit() {     SetTimer("SavePlayerStats", 1000, true);     return 1; } public SavePlayerStats() {     new Float:hp, Float:ar;     foreach(new i : Player) // foreach      {         GetPlayerHealth(i, hp);         GetPlayerArmour(i, ar);         User[i][USER_HEALTH] = hp;         User[i][USER_ARMOR] = ar;         User[i][USER_SKIN] = GetPlayerSkin(i);         // CONTINUE FOR MORE STATS     }     return 1; }  EDIT ; You cannot use Get functions under OnPlayerDisconnect.

Bad Practice!

- Constant One second timer.
- Saving all player's statistics at once.

Increase the timer (Every -- 5mins). Save Statistics for players individually.

[xMoBi]

is your problem fixed?

[Sew_Sumi]

Quote:

Originally Posted by ISmokezU Bad Practice! - Constant One second timer. - Saving all player's statistics at once. Increase the timer (Every -- 5mins). Save Statistics for players individually.

It's not bad practice to use a one second timer, it's bad practice to use it, overload it, and not expect issues.

As you say though, 3-5 mins between account saves.

[Voxel]

Quote:

Originally Posted by Logic_ It should be REAL not INTEGER for float values ^^

so it should be?

pawn Код:

lastx REAL DEFAULT 0 NOT NULL, lasty REAL DEFAULT 0 NOT NULL, lastz REAL DEFAULT 0 NOT NULL

Quote:

Originally Posted by AjaxM EDIT ; You cannot use Get functions under OnPlayerDisconnect.

Ahhh for real, all right thanks!