[baki]

I have a problem with ym /admins command when i get in the players rank changes to Server Owner but when im out he is back to his normal rank

PHP код:

CMD:admins(playerid, params[])
{
    new id;
    new n[MAX_PLAYER_NAME];
    new count = 0, string19[256];
    GetPlayerName(id,n,sizeof(n));
    for(new i = 0; i < MAX_PLAYERS; i ++)
    {
    if(IsPlayerConnected(i))
    {
    if(GetPVarInt(i, "PlayerAdminLevel") < 1)
    {
    format(string19, sizeof(string19), "Trial Moderator : %s (%i)",n ,playerid);
    count++;
    }
    if(GetPVarInt(i, "PlayerAdminLevel") < 2)
    {
    format(string19, sizeof(string19), "Moderator : %s (%i)",n ,playerid);
    count++;
    }
    if(GetPVarInt(i, "PlayerAdminLevel") < 3)
    {
    format(string19, sizeof(string19), "Administrator : %s (%i)",n ,playerid);
    count++;
    }
    if(GetPVarInt(i, "PlayerAdminLevel") < 4)
    {
    format(string19, sizeof(string19), "Chief Administrator : %s (%i)",n ,playerid);
    count++;
    }
    if(GetPVarInt(i, "PlayerAdminLevel") < 5)
    {
    format(string19, sizeof(string19), "Server Owner : %s (%i)",n ,playerid);
    count++;
    }
    }
    }
    if(count == 0)
    {
    SendClientMessage(playerid, COLOR_GREEN, "");
    SendClientMessage(playerid, COLOR_GREEN, "|======== Online Admins =======|");
    SendClientMessage(playerid, COLOR_WHITE, "- No Admins Online at Time!");
    SendClientMessage(playerid, COLOR_GREEN, "|==============================|");
    SendClientMessage(playerid, COLOR_GREEN, "");
    }
    else
    {
    SendClientMessage(playerid, COLOR_GREEN, "");
    SendClientMessage(playerid, COLOR_GREEN, "|======== Online Admins =======|");
    SendClientMessage(playerid, COLOR_WHITE, string19);
    SendClientMessage(playerid, COLOR_GREEN, "|==============================|");
    SendClientMessage(playerid, COLOR_GREEN, "");
    }
    return 1;
} 


[FuNkYTheGreat]

The problem isn't in the command, its just showing online admins, Please show us the code where you saves the player admin level , or if you didn't than save it, by using Y INI, its much easy/simple.

[Vince]

Basic logic operators: < means smaller than, > means greater than. Although in this situation it is much better to use a switch instead because there is no fall-through.

PHP код:

new title[24];
        
switch(GetPVarInt(i, "PlayerAdminLevel"))
{
    case 1: title = "Trial Moderator";
    case 2: title = "Moderator";
    case 3: title = "Administrator";
    case 4: title = "Chief Administrator";
    case 5: title = "Server Owner";
}

format(string19, sizeof(string19), "%s : %s (%i)", title, n, playerid);
count++; 


Much shorter, much cleaner, less unnecessary repetition.

[pabloalber84ban]

Quote:

Originally Posted by Vince Basic logic operators: < means smaller than, > means greater than. Although in this situation it is much better to use a switch instead because there is no fall-through. PHP код: new title[24];          switch(GetPVarInt(i, "PlayerAdminLevel")) {     case 1: title = "Trial Moderator";     case 2: title = "Moderator";     case 3: title = "Administrator";     case 4: title = "Chief Administrator";     case 5: title = "Server Owner"; } format(string19, sizeof(string19), "%s : %s (%i)", title, n, playerid); count++;  Much shorter, much cleaner, less unnecessary repetition.

This save much unnecessary code:

Код:

new const AdminLevels[6][] = {
	{"User"},
	{"Trial Moderator"},
	{"Moderator"},
	{"Administrator"},
	{"Chief Administrator"},
	{"Server Owner"},
}

Код:

AdminsLevels[GetPVarInt(i, "PlayerAdminLevel")]