1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
Help with command
Zmith
Big Clucker
***
Posts: 76
Threads: 23
Joined: Jun 2013
Reputation: 0
#1

18.03.2017, 04:44
How can I fix this? look at screenshot for detail on the problem.

Код:
CMD:g2(playerid, params[])
{
    new string[256], text[100];
    if(sscanf(params, "s[100]", text)) return SendClientMessage(playerid, -1, "{6a696a}[cmd]: /g(lobalchat) {9c9a9c}[msg]");
    for(new i = 0; i < MAX_PLAYERS; i ++)
    {
	    if(IsPlayerConnected(i))
	    {
	    
	    	if(pInfo[i][VIPlevel] == 0)
		    {
			    format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}%s: %s", GetName(playerid), text);
			    SendClientMessageToAll(COLOR_SERVER, string);
		    }
	    	if(pInfo[i][VIPlevel] == 1)
		    {
			    format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}VIP %s: %s", GetName(playerid), text);
			    SendClientMessageToAll(COLOR_SERVER, string);
		    }
		    if(pInfo[i][Adminlevel] == 1)
		    {
			    format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Trial Admin%s: %s", GetName(playerid), text);
			    SendClientMessageToAll(COLOR_SERVER, string);
		    }
		    if(pInfo[i][Adminlevel] == 2)
		    {
			    format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Basic Admin %s: %s", GetName(playerid), text);
			    SendClientMessageToAll(COLOR_SERVER, string);
		    }
		    if(pInfo[i][Adminlevel] == 3)
		    {
			    format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Senior Admin %s: %s", GetName(playerid), text);
			    SendClientMessageToAll(COLOR_SERVER, string);
		    }
		    if(pInfo[i][Adminlevel] == 4)
		    {
			    format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Anon: %s", text);
			    SendClientMessageToAll(COLOR_SERVER, string);
		    }
		    if(pInfo[i][Adminlevel] == 5)
		    {
			    format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Head Admin %s: %s", GetName(playerid), text);
			    SendClientMessageToAll(COLOR_SERVER, string);
		    }
		    if(pInfo[i][Adminlevel] == 6)
		    {
			    format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Anon: %s", text);
			    SendClientMessageToAll(COLOR_SERVER, string);
		    }
		    if(pInfo[i][Adminlevel] == 7)
		    {
			    format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Owner %s: %s", GetName(playerid), text);
			    SendClientMessageToAll(COLOR_SERVER, string);
		    }
	    }
    }
    return 1;
}
Find
Reply
Toroi
Gangsta
****
Posts: 701
Threads: 7
Joined: Feb 2017
Reputation: 0
#2

18.03.2017, 05:27
add returns to every condition to make sure the next one wont execute.
Find
Reply
jlalt
Banned
Posts: 1,266
Threads: 6
Joined: Oct 2014
#3

18.03.2017, 05:31
Make your checks by verse [ highest to lowest ] and after the first if(... use else if intead of only if.
I'm on phone now so can not fix only can suggest how to fix it xd.
Find
Reply
SyS
High-roller
*****
Posts: 1,939
Threads: 11
Joined: Oct 2015
Reputation: 0
#4

18.03.2017, 05:54
use switch
Find
Reply
Toroi
Gangsta
****
Posts: 701
Threads: 7
Joined: Feb 2017
Reputation: 0
#5

18.03.2017, 05:56
but there are 2 different conditions
Find
Reply
Mic_H
Big Clucker
***
Posts: 178
Threads: 7
Joined: Oct 2011
Reputation: 0
#6

18.03.2017, 06:55
( Последний раз редактировалось Mic_H; 18.03.2017 в 08:58. )
PHP код:
#define MAX_ADMINLVL 8
new AdminRanks[MAX_ADMINLVL][13] = {
    "Player",
    "Trial Admin",
    "Basic Admin",
    "Senior Admin",
    "Anon",
    "Head Admin",
    "Anon",
    "Owner"
};
stock ServerStatus(playerid)
{
    new status[15] = "Player";
    if(pInfo[playerid][Adminlevel] > 0 && pInfo[playerid][Adminlevel] < MAX_ADMINLVL)
    {
        status = AdminRanks[pInfo[playerid][Adminlevel]]; //Admin -> First Priority
    }
    else if(pInfo[playerid][Adminlevel] >= MAX_ADMINLVL) //Edited '>' -> '>='
    {
        status = "Pro-Owner";
    }
    else if(pInfo[playerid][VIPlevel] > 0) // VIP -> Second
    {
        status = "VIP";
    }
    return status;
}
CMD:g2(playerid, params[])
{
    new string[256], text[100];
    if(sscanf(params, "s[100]", text)) return SendClientMessage(playerid, -1, "{6a696a}[cmd]: /g(lobalchat) {9c9a9c}[msg]");
    format(string, sizeof(string), "{A9C4E4}[Global Chat] {EAEAEA}%s %s: %s", ServerStatus(playerid), GetName(playerid), text);
    
    //foreach(Player, i)
    for(new i = 0; i <= GetPlayerPoolSize(); i++) //Edited '<=', else the last guy won't get the message :P
    {
        if(IsPlayerConnected(i))
        {
            SendClientMessage(i, COLOR_SERVER, string);
        }
    }
    /*
    Mistakes:>
    1. You were sending to ALL players.... So 10 players IG = 10 messages..
    2. You were using Ifs, not if-else if.. = Messages have a chance of being sent 3-4Times i.e., if a player is a VIP, Admin.
    for(new i = 0; i < MAX_PLAYERS; i ++)
    {
        if(IsPlayerConnected(i))
        {
        
            if(pInfo[i][VIPlevel] == 0)
            {
                format(string, sizeof string, "%s: %s", GetName(playerid), text);
            }
            if(pInfo[i][VIPlevel] == 1)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}VIP %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 1)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Trial Admin%s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 2)
            {
                format(string, sizeof string, "{}[Global Chat] {EAEAEA}Basic Admin %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 3)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Senior Admin %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 4)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Anon: %s", text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 5)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Head Admin %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 6)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Anon: %s", text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 7)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Owner %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
        }
    }*/
    return 1;
} 
Find
Reply
Zmith
Big Clucker
***
Posts: 76
Threads: 23
Joined: Jun 2013
Reputation: 0
#7

18.03.2017, 13:47
Quote:
Originally Posted by Mic_H
Посмотреть сообщение
PHP код:
#define MAX_ADMINLVL 8
new AdminRanks[MAX_ADMINLVL][13] = {
    "Player",
    "Trial Admin",
    "Basic Admin",
    "Senior Admin",
    "Anon",
    "Head Admin",
    "Anon",
    "Owner"
};
stock ServerStatus(playerid)
{
    new status[15] = "Player";
    if(pInfo[playerid][Adminlevel] > 0 && pInfo[playerid][Adminlevel] < MAX_ADMINLVL)
    {
        status = AdminRanks[pInfo[playerid][Adminlevel]]; //Admin -> First Priority
    }
    else if(pInfo[playerid][Adminlevel] >= MAX_ADMINLVL) //Edited '>' -> '>='
    {
        status = "Pro-Owner";
    }
    else if(pInfo[playerid][VIPlevel] > 0) // VIP -> Second
    {
        status = "VIP";
    }
    return status;
}
CMD:g2(playerid, params[])
{
    new string[256], text[100];
    if(sscanf(params, "s[100]", text)) return SendClientMessage(playerid, -1, "{6a696a}[cmd]: /g(lobalchat) {9c9a9c}[msg]");
    format(string, sizeof(string), "{A9C4E4}[Global Chat] {EAEAEA}%s %s: %s", ServerStatus(playerid), GetName(playerid), text);
    
    //foreach(Player, i)
    for(new i = 0; i <= GetPlayerPoolSize(); i++) //Edited '<=', else the last guy won't get the message :P
    {
        if(IsPlayerConnected(i))
        {
            SendClientMessage(i, COLOR_SERVER, string);
        }
    }
    /*
    Mistakes:>
    1. You were sending to ALL players.... So 10 players IG = 10 messages..
    2. You were using Ifs, not if-else if.. = Messages have a chance of being sent 3-4Times i.e., if a player is a VIP, Admin.
    for(new i = 0; i < MAX_PLAYERS; i ++)
    {
        if(IsPlayerConnected(i))
        {
        
            if(pInfo[i][VIPlevel] == 0)
            {
                format(string, sizeof string, "%s: %s", GetName(playerid), text);
            }
            if(pInfo[i][VIPlevel] == 1)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}VIP %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 1)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Trial Admin%s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 2)
            {
                format(string, sizeof string, "{}[Global Chat] {EAEAEA}Basic Admin %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 3)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Senior Admin %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 4)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Anon: %s", text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 5)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Head Admin %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 6)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Anon: %s", text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
            if(pInfo[i][Adminlevel] == 7)
            {
                format(string, sizeof string, "{A9C4E4}[Global Chat] {EAEAEA}Owner %s: %s", GetName(playerid), text);
                SendClientMessageToAll(COLOR_SERVER, string);
            }
        }
    }*/
    return 1;
} 
error 017: undefined symbol "GetPlayerPoolSize"
Find
Reply
coool
Gangsta
****
Posts: 637
Threads: 23
Joined: Feb 2013
Reputation: 0
#8

18.03.2017, 13:48
You don't have the latest sa-mp version
try " MAX_PLAYERS " rather than GetPlayerPoolSize
Find
Reply
Bolex_
Gangsta
****
Posts: 586
Threads: 14
Joined: Aug 2015
Reputation: 0
#9

18.03.2017, 13:57
Update your server to newest 0.3.7 correctly! (http://www.sa-mp.com/download.php)
Find
Reply
Zmith
Big Clucker
***
Posts: 76
Threads: 23
Joined: Jun 2013
Reputation: 0
#10

18.03.2017, 14:30
It's fixed! Thanks for the help everyone rep+
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help