[JasonMorelli]

Hello guys , i have a problem in my server i use SCRP like gm and i found a problem
Anybody can start the vehicle even if it's not the propriate
CMD:engine

Quote:

CMD:moteur(playerid, params[]) { new vehicleid = GetPlayerVehicleID(playerid); new id = Car_Inside(playerid); if (Car_IsOwner(playerid, id) || (PlayerData[playerid][pFaction] != -1 && CarData[id][carFaction] == GetFactionType(playerid))) if (!IsEngineVehicle(vehicleid)) return SendErrorMessage(playerid, "Vous n'кtes pas dans le vйhicule."); /* if (IsRefueling[playerid]) return SendErrorMessage(playerid, "Wait until the car tank is refueled.");*/ if (GetPlayerState(playerid) != PLAYER_STATE_DRIVER) return SendErrorMessage(playerid, "Vous ne pouvez pas allumer le moteur car vous n'кtes pas le conducteur du vйhicule."); if (CoreVehicles[vehicleid][vehFuel] < 1) return SendErrorMessage(playerid, "Vous n'avez plus d'essence dans votre vйhicule , le moteur ne dйmarre pas"); if (ReturnVehicleHealth(vehicleid) <= 300) return SendErrorMessage(playerid, "Vous avez un problиme technique dans votre vйhicule , le moteur ne dйmarre pas."); for(new i = 0; i < sizeof(dmvCars); i++) { if(IsPlayerInVehicle(playerid, dmvCars[i])) { if (!PlayerData[playerid][pDrivingTest]) return SendClientMessage(playerid, -1, "Ecrivez /permis pour commencer votre test de conduite"); } } for(new i = 0; i < sizeof(rentCars); i++) { if(IsPlayerInVehicle(playerid, rentCars[i])) { if(GetPVarInt(playerid, "RentedCar") == 0 && GetPVarInt(playerid, "RentVehKey") == 0) return SendClientMessage(playerid, -1, "Vous n'avez pas les clefs de ce vйhicule."); if(GetPVarInt(playerid, "RentedCar") == 1 && GetPVarInt(playerid, "RentVehKey") == 0) return SendClientMessage(playerid, -1, "Vous n'avez pas les clefs de ce vйhicule."); if(GetPVarInt(playerid, "RentedCar") == 1 && GetPVarInt(playerid, "RentVehKey") != vehicleid) return SendClientMessage(playerid, -1, "Vous n'avez pas les clefs de ce vйhicule."); } } switch (GetEngineStatus(vehicleid)) { case false: { SetEngineStatus(vehicleid, true); ShowPlayerFooter(playerid, "vous avez ~g~demarre~w~ le moteur!"); SendNearbyMessage(playerid, 30.0, COLOR_PURPLE, "** %s dйmarre le moteur du vйhicule.", ReturnName(playerid, 0)); } case true: { SetEngineStatus(vehicleid, false); ShowPlayerFooter(playerid, "vous avez ~r~eteint~w~ le moteur!"); SendNearbyMessage(playerid, 30.0, COLOR_PURPLE, "** %s йteint le moteur du vйhicule.", ReturnName(playerid, 0)); } } return 1; }

Some help pls and sorry for my bad english

[JasonMorelli]

Please up

[Sew_Sumi]

24 hour bumps only.

Your use of { } without indentation makes your code terrible to read.

You use some { } and some without. You should keep to the same structure, as then you'd likely be able to read your own code.