[TwinkiDaBoss]

Alright so the problem is simple, getting closest vehicle to me isnt working. Nothing basically happends

PHP код:

if(PRESSED(KEY_FIRE )) {
        if(pState == PLAYER_STATE_ONFOOT) {
             new somecar = GetClosestVehicleForPlayer(playerid);
             new engine, lights, alarm, doors, bonnet, boot, objective;
             if(VehInfo[somecar][VehMasterID] == AccInfo[playerid][ID] || VehInfo[somecar][VehFaction] == AccInfo[playerid][PlayerFaction]) {
                if(VehInfo[somecar][VLock] == 0) {
                            VehInfo[somecar][VLock] = 1;
                            GameTextForPlayer(playerid,"~r~Vehicle Locked",2000,4);
                              GetVehicleParamsEx(somecar, engine, lights, alarm, doors, bonnet, boot, objective);
                            SetVehicleParamsEx(somecar, engine, lights, alarm, 1, bonnet, boot, objective);
                }
                else if(VehInfo[somecar][VLock] == 1) {
                            VehInfo[somecar][VLock] = 0;
                            GameTextForPlayer(playerid,"~r~Vehicle Unlocked",2000,4);
                            GetVehicleParamsEx(somecar, engine, lights, alarm, doors, bonnet, boot, objective);
                            SetVehicleParamsEx(somecar, engine, lights, alarm, 0, bonnet, boot, objective);
                }
            }
        }
    }
GetClosestVehicleForPlayer(playerid)
{
    new vehicleid = INVALID_VEHICLE_ID;
    new Float:distance = 99999.0;
    new Float:X, Float:Y, Float:Z;
    GetPlayerPos(playerid, X, Y, Z);
    for(new i = 0; i < MAX_VEHICLES; i++)
    {
        if(GetVehicleDistanceFromPoint(i, X, Y, Z) < distance && distance < 5.0) //you can change this value
        {
            vehicleid = i;
            distance = GetVehicleDistanceFromPoint(i, X, Y, Z);
        }
    }
    return vehicleid;
} 


[Antonio144]

You instantiated variable distance with a value of 99999.0, then in your first if statement you check if the distance is less than 5.0 which is false. So all the possible combinations are (false && false) = false and (true, false) = false. which means it will never enter first if block.

Код:

GetClosestVehicleForPlayer(playerid)
{
    new vehicleid = INVALID_VEHICLE_ID;
    new Float:distance = 99999.0;
    new Float:X, Float:Y, Float:Z;
    GetPlayerPos(playerid, X, Y, Z);
    for(new i = 0; i < MAX_VEHICLES; i++)
    {
        if(!IsValidVehicle(i)) continue;
        new Float: tmp = GetVehicleDistanceFromPoint(i, X, Y, Z);
        if(tmp > distance) continue;
        vehicleid = i;
        distance = tmp;
    }
    return vehicleid;
}

NOTE:code not tested

[TwinkiDaBoss]

Ahaaaaaaaaaaaaa thanks ! +rep it works