[ahameed4755]

hi i made a /givescore and it works but the string doesn't work

Код:

CMD:givescore(playerid,params[])
{
if(!IsPlayerAdmin(playerid))return SendClientMessage(playerid, COLOR_ERROR,"[ERROR]:you are not rcon admin");
new targetid,str[75],pname[MAX_PLAYER_NAME],score;
GetPlayerName(targetid);
if(sscanf(params,"ud",targetid,score)) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR]:Usage(playerid)");
if(targetid == INVALID_PLAYER_ID) return SendClientMessage(playerid, COLOR_ERROR, "[ERROR]:Player is not connected.");
GetPlayerScore(targetid);
SetPlayerScore(targetid,score);
format(str, sizeof(str), "admin has given you %d score.",score);
SendClientMessage(playerid,COLOR_YELLOW,"you have given %d score to %i",score,targetid);
SendClientMessage(targetid,COLOR_PURPLE,str);
return 1;
}

the string gives me random numbers!

[XBrianX]

Quote:

Originally Posted by ahameed4755 hi i made a /givescore and it works but the string doesn't work Код: CMD:givescore(playerid,params[]) { if(!IsPlayerAdmin(playerid))return SendClientMessage(playerid, COLOR_ERROR,"[ERROR]:you are not rcon admin"); new targetid,str[75],pname[MAX_PLAYER_NAME],score; GetPlayerName(targetid); if(sscanf(params,"ud",targetid,score)) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR]:Usage(playerid)"); if(targetid == INVALID_PLAYER_ID) return SendClientMessage(playerid, COLOR_ERROR, "[ERROR]:Player is not connected."); GetPlayerScore(targetid); SetPlayerScore(targetid,score); format(str, sizeof(str), "admin has given you %d score.",score); SendClientMessage(playerid,COLOR_YELLOW,"you have given %d score to %i",score,targetid); SendClientMessage(targetid,COLOR_PURPLE,str); return 1; } the string gives me random numbers!

Your command looks fine to me but you can use this

PHP код:

CMD:setscore(playerid, params[])
{
    //check if the player is a admin
    CheckPlayerAdminLevel(playerid, 3);
    new target, amount;
    if(sscanf(params, "ui", target, amount)) return SendClientMessagef(playerid, X11_THISTLE_1, "USAGE: /setscore [player] [amount]");
    if(! IsPlayerConnected(target)) return SendClientMessage(playerid, X11_FIREBRICK, "ERROR: The specified player is not conected.");
    if(GetPlayerGAdminLevel(playerid) < GetPlayerGAdminLevel(target)) return SendClientMessage(playerid, X11_FIREBRICK, "ERROR: You cannot use this command on higher level admin.");
    SetPlayerScore(target, amount);
    PlayerPlaySound(target, 1057, 0.0, 0.0, 0.0);
    PlayerPlaySound(playerid, 1057, 0.0, 0.0, 0.0);
    SendClientMessagef(target, X11_DODGER_BLUE, "Admin %s[%i] have set your score to %i.", ReturnPlayerName(playerid), playerid, amount);
    SendClientMessagef(playerid, X11_DODGER_BLUE, "You have set %s[%i]'s score to %i.", ReturnPlayerName(target), target, amount);
    return 1;
} 


[Sjn]

Well, its because the message that was sent to the cmd user (Admin) wasn't formatted. You only formatted the message that was sent to the target player. Also, i saw that you have fetched target player's name but didn't utilize it at all.

PHP код:

CMD:givescore(playerid, params[])
{
    if(!IsPlayerAdmin(playerid))
        return SendClientMessage(playerid, COLOR_ERROR, "[ERROR]: You are not an admin!");

    new targetid, score;
    
    if(sscanf(params, "ud", targetid, score))
        return SendClientMessage(playerid, COLOR_ERROR, "[ERROR]: Usage /givescore [playerid] [amount]");

    if(targetid == INVALID_PLAYER_ID)
        return SendClientMessage(playerid, COLOR_ERROR, "[ERROR]: Player is not connected.");

    new str[75], pname[MAX_PLAYER_NAME];
    GetPlayerName(targetid, pname, MAX_PLAYER_NAME);
    
    SetPlayerScore(targetid, GetPlayerScore(targetid) + score);
    
    format(str, sizeof(str), "Admin has given you %d score.", score);
    SendClientMessage(targetid, COLOR_PURPLE, str);
    
    format(str, sizeof(str), "you have given %d score to %s(%d)", score, pname, targetid);
    SendClientMessage(playerid, COLOR_YELLOW, str);
    return 1;
} 


[ahameed4755]

Quote:

Originally Posted by Sjn Well, its because the message that was sent to the cmd user (Admin) wasn't formatted. You only formatted the message that was sent to the target player. Also, i saw that you have fetched target player's name but didn't utilize it at all. PHP код: CMD:givescore(playerid, params[]) {     if(!IsPlayerAdmin(playerid))         return SendClientMessage(playerid, COLOR_ERROR, "[ERROR]: You are not an admin!");     new targetid, score;          if(sscanf(params, "ud", targetid, score))         return SendClientMessage(playerid, COLOR_ERROR, "[ERROR]: Usage /givescore [playerid] [amount]");     if(targetid == INVALID_PLAYER_ID)         return SendClientMessage(playerid, COLOR_ERROR, "[ERROR]: Player is not connected.");     new str[75], pname[MAX_PLAYER_NAME];     GetPlayerName(targetid, pname, MAX_PLAYER_NAME);          SetPlayerScore(targetid, GetPlayerScore(targetid) + score);          format(str, sizeof(str), "Admin has given you %d score.", score);     SendClientMessage(targetid, COLOR_PURPLE, str);          format(str, sizeof(str), "you have given %d score to %s(%d)", score, pname, targetid);     SendClientMessage(playerid, COLOR_YELLOW, str);     return 1; }

ty! +rep!