[HeLiOn_PrImE]

I want to make a nitrous indicator, and for that I created a variable with the duration.
I wanted to substract every second the nitrous button is pressed so I made a timer with a function.
It wasn't working well, so I included client messages to see the values changing while I keep the button pressed.
The code is below:

PHP код:

new string[64];
new amount = 0;
new one = 1;
forward amountfeed(playerid);
public amountfeed(playerid)
{
    format(string,sizeof(string),"%d", amount);
    SendClientMessage(playerid,0xFFFFFFAA,string);
    amount = floatsub(amount, one);  ///////////////////
    return 1;
}
public OnPlayerEnterVehicle(playerid, vehicleid, ispassenger)
{
    amount = 10;
    format(string,sizeof(string),"%d", amount);
    SendClientMessage(playerid,0xFFFFFFAA,string);
    return 1;
}
public OnPlayerExitVehicle(playerid, vehicleid)
{
    amount = 0;
}
public OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
    if(IsPlayerInAnyVehicle(playerid))
    {
        new timer;
        new veh = GetPlayerVehicleID(playerid);
        if((newkeys & 1 || newkeys & 4))
        {
            timer = SetTimer("amountfeed", 1000, true);
            if (amount == 0)
            {
                KillTimer(timer);
            }
        }
        
        if((oldkeys & 1 || oldkeys & 4))
        {
            KillTimer(timer);
        }
        
    }
    return 1;
} 


Basically when I enter a car I should get the value 10, I start holding the NOS button, the value should drop to 1 every second.
Clearly something is terribly wrong here, because Instead of 9, 8, 7, etc, I got the following:
BTW I also got a tag mismatch warning on the line marked with ///////////////////

PHP код:

//I entered the vehicle
[08:36:34] 10
//I started holding click (Nos button of course)
[08:36:44] 10
[08:36:45] 1091567616
[08:36:46] 1317150720
[08:36:47] 1318913088
[08:36:48] 1318926856
[08:36:50] 1318926964
[08:36:51] 1318926965
[08:36:52] 1318926965
[08:36:53] 1318926965
[08:36:54] 1318926965
[08:36:55] 1318926965
[08:36:56] 1318926965
[08:36:57] 1318926965
[08:36:58] 1318926965
[08:37:00] 1318926965
[08:37:01] 1318926965
[08:37:02] 1318926965
[08:37:03] 1318926965
[08:37:04] 1318926965
[08:37:05] 1318926965
[08:37:06] 1318926965
[08:37:07] 1318926965
[08:37:08] 1318926965
[08:37:09] 1318926965 


Can someone point me in the right direction here?

[Lordzy]

There's no need of using floatsub on an integer. You could simply do the following instead of subtracting it using floatsub:

pawn Код:

amount--;

;

[HeLiOn_PrImE]

Thank you, that did the trick with the numbers. But now I'm facing another issue.
The timer should stop when I release the nos button or when the value reaches 0, but it doesn't. The values go below 0 and keep dropping. The new code is this:

PHP код:

#define FILTERSCRIPT
#include <a_samp>
#if defined FILTERSCRIPT
new string[64];
new amount = 0;
new timer;
forward amountfeed(playerid);
public amountfeed(playerid)
{
    format(string,sizeof(string),"%d", amount);
    SendClientMessage(playerid,0xFFFFFFAA,string);
    amount--;
    if (amount == 0)
    {KillTimer(timer);}
    return 1;
}
public OnFilterScriptInit()
{
    print("\n--------------------------------------");
    print(" Blank Filterscript by your name here");
    print("--------------------------------------\n");
    return 1;
}
public OnFilterScriptExit()
{
    print("--------------------------------------\n");
    return 1;
}
public OnPlayerDisconnect(playerid, reason)
{
    amount = 0;
    KillTimer(timer);
}
public OnPlayerEnterVehicle(playerid, vehicleid, ispassenger)
{
    amount = 10;
    format(string,sizeof(string),"%d", amount);
    SendClientMessage(playerid,0xFFFFFFAA,string);
    return 1;
}
public OnPlayerExitVehicle(playerid, vehicleid)
{
    amount = 0;
    KillTimer(timer);
}
public OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
    if(IsPlayerInAnyVehicle(playerid))
    {
        
        new veh = GetPlayerVehicleID(playerid);
        if((newkeys & 1 || newkeys & 4))
        {
            timer = SetTimer("amountfeed", 1000, true);
            if (amount == 0)
            {
                KillTimer(timer);
            }
        }
        
        if((oldkeys & 1 || oldkeys & 4))
        {
            KillTimer(timer);
        }
        
    }
    return 1;
} 


[Evocator]

I managed the floats, idk why but incase you need to subtract less than 1. Also try the timer now, i fixed ur bit masking.

Код:

#define RELEASED(%0) \
    (((newkeys & (%0)) != (%0)) && ((oldkeys & (%0)) == (%0)))


new string[64]; 
new Float:amount = 0; 

forward amountfeed(playerid); 
public amountfeed(playerid) 
{ 
    format(string,sizeof(string),"%f", amount); 
    SendClientMessage(playerid,0xFFFFFFAA,string); 
    amount = floatsub(amount, 1.0);
    return 1; 
} 

public OnPlayerEnterVehicle(playerid, vehicleid, ispassenger) 
{ 
    amount = 10.0; 
    format(string,sizeof(string),"%f", amount); 
    SendClientMessage(playerid,0xFFFFFFAA,string); 
    return 1; 
} 

public OnPlayerExitVehicle(playerid, vehicleid) 
{ 
    amount = 0.0; 
}

public OnPlayerKeyStateChange(playerid, newkeys, oldkeys) 
{ 
    if (IsPlayerInAnyVehicle(playerid)) 
    { 
        new timer; 
        new veh = GetPlayerVehicleID(playerid);

        if ( ((newkeys & 1) && !(oldkeys & 1)) || ((newkeys & 4) && !(oldkeys & 4)) )
        { 
            timer = SetTimer("amountfeed", 1000, true); 
            if (amount < 1) 
            { 
                KillTimer(timer); 
            } 
        } 
         
        if (RELEASED(1) || RELEASED(4))  
        { 
            KillTimer(timer); 
        }
    }
    return 1; 
}

[HeLiOn_PrImE]

Yes, the timer appears to be working now, but I just decremented the amount value, no need to subtract.
The amount value doesn't seem to reach 0, tough. It stays at 1.

Edit: solved it guys. Thanks a lot, I added rep to both of you.