[Arxalan]

Hello i made a TextDraw known as Premium Points . but it don't update when i give or take premium points from someone . Following is the codes.

PHP код:

stock load_pp(playerid)
{
    Textdraw1 = CreatePlayerTextDraw(playerid,501.000000, 100.000000, "Premium Points: 69");
    PlayerTextDrawBackgroundColor(playerid,Textdraw1, -1);
    PlayerTextDrawFont(playerid,Textdraw1, 1);
    PlayerTextDrawLetterSize(playerid,Textdraw1, 0.320000, 0.799999);
    PlayerTextDrawColor(playerid,Textdraw1, 65535);
    PlayerTextDrawSetOutline(playerid,Textdraw1, 1);
    PlayerTextDrawSetProportional(playerid,Textdraw1, 1);
    PlayerTextDrawUseBox(playerid,Textdraw1, 1);
    PlayerTextDrawBoxColor(playerid,Textdraw1, 0x00000044);
    PlayerTextDrawTextSize(playerid,Textdraw1, 606.000000, 0.000000);
    PlayerTextDrawSetSelectable(playerid,Textdraw1, 0);
    return 1;
} 


I added the following command in OnPlayerSpawn()

PHP код:

PlayerTextDrawShow(playerid, Textdraw1); 


At OnPlayerDisconnet()

PHP код:

    PlayerTextDrawHide(playerid, Textdraw1); 


Public UpdatePlayer() is following ( i also did the forward for UpdatePlayer)

PHP код:

public UpdatePlayer()
{
    new string[256];
    foreach(new i : Player)
    {
        format(string, 128, "Premium Points: %d", User[i][accountPP]);
        PlayerTextDrawSetString(i, Textdraw1, string);
    }
    return 1;
} 


OnPlayerConnect()

PHP код:

    load_pp(playerid); 


And the following in OnPlayerDisconnect()

PHP код:

    PlayerTextDrawHide(playerid, Textdraw1);
unloadpp(playerid); 


Following is the commands of giving and taking premium points.

Taking Premium points:

PHP код:

CMD:takepp(playerid, params[])
{
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] >= 3)
    {
        new string[150], id, amount;
        if(sscanf(params, "ui", id, amount)) return SendClientMessage(playerid, COLOR_RED, "USAGE: /givepp [playerid] [amount]");
        if(id == INVALID_PLAYER_ID) return SendClientMessage(playerid, -1, "» "red"Player not connected.");
        if(User[id][accountLogged] == false) return SendClientMessage(playerid, -1, "» "red"Player not logged in.");
        if(User[id][accountPP] < amount) return SendClientMessage(playerid, 0xFF0000FF, "This Player Dont Have That Much Points!");
        format(string, 150, "[PREMIUM POINTS] "red"%s has taken %s [%d] Premium Points.", GetName(playerid), GetName(id), amount);
        SendAMessage(-1, string);
        format(string, 150, ""green"[PREMIUM POINTS] "white"You have received "grey"%d "white"premium points from an "red"admin"white".", amount, User[id][accountPP]-amount);
        SendClientMessage(id, -1, string);
        format(string, 150, "» You have lost{%06x}%s "white"premium points of "grey"%d"white".", GetPlayerColor(id) >>> 8, GetName(id), amount);
        SendClientMessage(playerid, -1, string);
        format(string, 128, "%s take %d Premium Point(s) from %s.", GetName(playerid), amount, GetName(id));
        Log("premium.txt", string);
        User[id][accountPP] -= amount;
    }
    else
    {
        SendClientMessage(playerid, -1, "» "red"You are not authorized to use this command.");
    }
    return 1;
} 


(I know there is some mistakes in Takepp of format .)

Giving Premium point:

PHP код:

CMD:givepp(playerid, params[])
{
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] >= 3)
    {
        new string[150], id, amount;
    
        if(sscanf(params, "ui", id, amount)) return SendClientMessage(playerid, COLOR_RED, "USAGE: /givepp [playerid] [amount]");
        if(id == INVALID_PLAYER_ID) return SendClientMessage(playerid, -1, "» "red"Player not connected.");
        if(User[id][accountLogged] == false) return SendClientMessage(playerid, -1, "» "red"Player not logged in.");
        format(string, 150, "[PREMIUM POINTS] "red"%s has given %s [%d] Premium Points.", GetName(playerid), GetName(id), amount);
        SendAMessage(-1, string);
        format(string, 150, ""green"[PREMIUM POINTS] "white"You have received "grey"%d "white"premium points from an "red"admin"white".", amount, User[id][accountPP]+amount);
        SendClientMessage(id, -1, string);
        format(string, 150, "» You have given {%06x}%s "white"premium points of "grey"%d"white".", GetPlayerColor(id) >>> 8, GetName(id), amount);
        SendClientMessage(playerid, -1, string);
        format(string, 128, "%s received %d Premium Points from %s.", GetName(id), amount, GetName(playerid));
        Log("premium.txt", string);
        User[id][accountPP] += amount;
    }
    else
    {
        SendClientMessage(playerid, -1, "» "red"You are not authorized to use this command.");
    }
    return 1;
} 


Setting Premium points :

PHP код:

CMD:setpremium(playerid, params[])
{
    new
        string[200],
        id,
        amount
    ;
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] >= 5)
    {
        if(sscanf(params, "ui", id, amount)) return SendClientMessage(playerid, COLOR_RED, "USAGE: /setpremium [playerid] [points]");
        if(id == INVALID_PLAYER_ID) return SendClientMessage(playerid, -1, "» "red"Player not connected.");
        if(User[id][accountLogged] == false) return SendClientMessage(playerid, -1, "» "red"Player not logged in.");
        format(string, 128, "[SET] "white"%s's Premium Point has been set to %d by %s.", GetName(id), amount, GetName(playerid));
        SendAMessage(COLOR_RED, string);
        format(string, 128, "[SET] "white"An admin has set your premium points to %d.", amount);
        SendClientMessage(id, COLOR_YELLOW, string);
        format(string, 128, "%s has been premium points set to %d by %s.", GetName(id), amount, GetName(playerid));
        Log("admin.txt", string);
        User[id][accountPP] = amount;
    }
    else
    {
        SendClientMessage(playerid, -1, "» "red"You are not authorized to use this command.");
    }
    return 1;
} 


[Sawalha]

callbacks will never be called except if there's a function to call them, Use a timer

pawn Код:

new pTimer[MAX_PLAYERS];
public OnPlayerConnect(playerid)
{
     pTimer[playerid] = SetTimerEx("UpdatePlayer", 1000, true, "i", playerid); // each second the textdraw will be updated
     return 1;
}

we made a timer variable , and a timer with params. Recommending you to edit your callback:

pawn Код:

public UpdatePlayer(playerid) 
{ 
    new string[128]; 
    format(string, 128, "Premium Points: %d", User[playerid][accountPP]); 
    PlayerTextDrawSetString(playerid, Textdraw0, string); 
    return 1; 
}

Set your string size to 128, you formatted it 128 and set as 256, that's a waste of memory and useless.


now:

pawn Код:

public OnPlayerDisconnect(playerid, reason)
{
      KillTimer(pTimer[playerid]);
      return 1;
}

Killing player's timer when he disconnects

[bgedition]

pawn Код:

OnGameModeInit() {
 SetTimer("UpdatePlayer", 500, true);
return 1;
}

[Arxalan]

@bgedition , i forgot to mention it . I already wrote that command of SetTimer.
@Sawalha thanks , +rep you and you too bgedition.

[Threshold]

EDIT: Removed, incorrect post.

[Arxalan]

@Sawalhan , will you tell me the code please of How to give Premium points to an offline player?

[Sawalha]

which saving method do you use?

[Arxalan]

MySql

[Vince]

Quote:

Originally Posted by Threshold Read this: https://sampwiki.blast.hk/wiki/TextDrawSetString I just added a note that reads: Quote: The text within the TextDraw will not be updated until TextDrawShowForPlayer or TextDrawShowForAll has been used.

This is NOT true and similar messages have been removed from that page several times earlier! For every other functions this holds true, EXCEPT for this one.

[Threshold]

Quote:

Originally Posted by Vince This is NOT true and similar messages have been removed from that page several times earlier! For every other functions this holds true, EXCEPT for this one.

Yeah, I had a feeling. My bad. I'll test it next time I jump to conclusions, I don't work with TextDraws very often.

EDIT: And I just realised that I have done this exact same thing in October 2014... I must be losing my mind...